From: Ilya Kosarev <i.kosarev@tarantool.org> To: imun@tarantool.org Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH v2] lua: assert on lua_gettop() negative return value Date: Tue, 21 Jul 2020 14:05:14 +0300 [thread overview] Message-ID: <20200721110514.10344-1-i.kosarev@tarantool.org> (raw) In case lua_gettop() called from encode_lua_call() returns negative value, we will segfault in iproto_reply_error() with empty diag, as far as it is unexpected error path not covered with diagnostics. Thus corresponding sane check with assert is introduced. Closes #4649 --- Branch: https://github.com/tarantool/tarantool/tree/i.kosarev/gh-4649-sane-check-on-lua_gettop Issue: https://github.com/tarantool/tarantool/issues/4649 Changes in v2: - added reasoning in comment src/box/lua/call.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/box/lua/call.c b/src/box/lua/call.c index ca871e077..516276a9f 100644 --- a/src/box/lua/call.c +++ b/src/box/lua/call.c @@ -361,6 +361,12 @@ encode_lua_call(lua_State *L) struct luaL_serializer *cfg = luaL_msgpack_default; int size = lua_gettop(port->L); + /* + * lua_gettop() might return negative value in case the internal state + * of the given Lua coroutine is seriously broken. In case of such + * behavior execution has to be aborted immediately. + */ + assert(size >= 0); for (int i = 1; i <= size; ++i) luamp_encode(port->L, cfg, &stream, i); port->size = size; -- 2.17.1
next reply other threads:[~2020-07-21 11:05 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-21 11:05 Ilya Kosarev [this message] 2020-07-21 11:54 ` Nikita Pettik 2020-07-21 12:12 ` Ilya Kosarev 2020-07-21 18:07 ` Igor Munkin 2020-07-21 18:19 ` Nikita Pettik
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200721110514.10344-1-i.kosarev@tarantool.org \ --to=i.kosarev@tarantool.org \ --cc=imun@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v2] lua: assert on lua_gettop() negative return value' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox