Tarantool development patches archive
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/1] txn_limbo: use fiber_clock() instead of fiber_time()
Date: Tue, 21 Jul 2020 01:09:31 +0300	[thread overview]
Message-ID: <20200720220931.GB4221@grain> (raw)
In-Reply-To: <917bd68fb91e1d113c65a2c74013371f379243a5.1595279482.git.v.shpilevoy@tarantool.org>

On Mon, Jul 20, 2020 at 11:11:39PM +0200, Vladislav Shpilevoy wrote:
> box.ctl.clear_synchro_queue() used fiber_time()
> instead of fiber_clock() to wait for a timeout. This is wrong,
> fiber_time() is realtime, not suitable for relative timeouts.
> 
> For that purpose always should be used monotonic clock. The patch
> fixes that.
> 
> Follow up #4849

(side note: monotonic clocks do not account acpi-deep-sleep state,
 ie when cpu is in sleep state it wont be accounted, but i think
 it is impossible scenario for us. so put this note just for
 reference).

Good catch!

Acked-by: Cyrill Gorcunov <gorcunov@gmail.com>

  reply	other threads:[~2020-07-20 22:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-20 21:11 Vladislav Shpilevoy
2020-07-20 22:09 ` Cyrill Gorcunov [this message]
2020-07-21 20:26   ` Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200720220931.GB4221@grain \
    --to=gorcunov@gmail.com \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 1/1] txn_limbo: use fiber_clock() instead of fiber_time()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox