Re: [Tarantool-patches] [PATCH] lua: do not use internal api in public headers

[Igor Munkin <imun@tarantool.org>]

Timur,

Thanks for your changes! It does solve your problem, but I propose to
drop this patch in favour of mine[1].

On 20.07.20, Timur Safin wrote:
> src/lua/utils.[ch] is part of public api which will
> be integrated into module.h at the build step. It
> should not refer to the internal LuaJIT API like
> lj_state_growstack1(), otherwise it has not chance
> to be linked in while building external binary module.
> 
> Relates to vshard-cluster-api#5

Side note: I doubt this line refers the issue the right way.

> ---
> 
> Branch: https://github.com/tarantool/tarantool/tree/tsafin/gh-vshard-cluster-api-5-no-private-api
> Issue: https://github.com/tarantool/vshard-cluster-api/issues/5
> 
>  src/lua/utils.c | 13 +++++++++++++
>  src/lua/utils.h | 14 ++------------
>  2 files changed, 15 insertions(+), 12 deletions(-)
> 

<snipped>

[1]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-July/018745.html

-- 
Best regards,
IM