From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 4/4] qsync: don't send negative timeouts into fiber_cond_wait_timeout
Date: Fri, 17 Jul 2020 23:43:51 +0300 [thread overview]
Message-ID: <20200717204351.GC2613@grain> (raw)
In-Reply-To: <20200717203336.GB2613@grain>
On Fri, Jul 17, 2020 at 11:33:36PM +0300, Cyrill Gorcunov wrote:
> On Fri, Jul 17, 2020 at 10:03:49PM +0200, Vladislav Shpilevoy wrote:
> > >
> > > Am I missing something obvious here?
> >
> > I still don't see how to trigger this assert. Please, show a code sample with
> > error injection, if you think that will help. I explicitly added line
> > 'timeout = -1;' and all worked fine.
> >
> ---
> [cyrill@grain test] ./test-run.py replication/qsync_basic.test.lua
> ...
> You did the same thing? Note that it requires debug build.
Actually it is different issue. I think you can safely drop this
patch.
next prev parent reply other threads:[~2020-07-17 20:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 14:44 [Tarantool-patches] [PATCH 0/4] qsync: continue cooking the code Cyrill Gorcunov
2020-07-14 14:44 ` [Tarantool-patches] [PATCH 1/4] qsync: add missing functions descriptions Cyrill Gorcunov
2020-07-14 14:44 ` [Tarantool-patches] [PATCH 2/4] qsync: drop txn_limbo_confirm_timeout Cyrill Gorcunov
2020-07-14 14:44 ` [Tarantool-patches] [PATCH 3/4] qsync: txn_limbo_wait_complete -- fix type conversion Cyrill Gorcunov
2020-07-14 14:44 ` [Tarantool-patches] [PATCH 4/4] qsync: don't send negative timeouts into fiber_cond_wait_timeout Cyrill Gorcunov
2020-07-14 14:53 ` [Tarantool-patches] [PATCH v2 " Cyrill Gorcunov
2020-07-16 22:45 ` Vladislav Shpilevoy
2020-07-17 7:25 ` Cyrill Gorcunov
2020-07-17 20:03 ` Vladislav Shpilevoy
2020-07-17 20:33 ` Cyrill Gorcunov
2020-07-17 20:43 ` Cyrill Gorcunov [this message]
2020-07-20 19:28 ` [Tarantool-patches] [PATCH 0/4] qsync: continue cooking the code Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200717204351.GC2613@grain \
--to=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 4/4] qsync: don'\''t send negative timeouts into fiber_cond_wait_timeout' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox