Re: [Tarantool-patches] [PATCH 2/2] msgpack: fix wrong mp_ext type in error message

[Sergey Kaplun <skaplun@tarantool.org>]

On 17.07.20, Alexander Turenko wrote:
> > > Well, I still don't get the reason for it. You can simply check your
> > > patch via a tiny Lua chunk for 1.10, otherwise the patch and the test
> > > are not necessary for the reasons I mentioned above.
> > 
> > I rewrote test to simple lua chunk (see it below).
> 
> +1 here, it is much simpler.
> 
> The Lua-written test does not fail on 2.4, but it is not a problem: in
> fact 2.4 is not affected by the problem (from a user point of view).
> 
> Re how to push: I would anyway push it from master downward, because the
> fixed code may become alive (I mean, not dead) in a future and we'll
> have the correct behaviour and the test. It is better than left it
> incorrect just because it is dead in fact.

We have a little bit different format of error at master ("Unsuported
MsgPack extension type: %u" vs "msgpack.decode: unsupported extension:
%u"). So the test will fail at master. Should I make some changes in
the test? Should I create branch from master directly (this branch is
checked out from 1.10)?

-- 
Best regards,
Sergey Kaplun