From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2/2] msgpack: fix wrong mp_ext type in error message
Date: Fri, 17 Jul 2020 12:09:42 +0300 [thread overview]
Message-ID: <20200717090942.s5niw2k5ezrzlety@tkn_work_nb> (raw)
In-Reply-To: <20200717083521.GA3979@root>
> > Well, I still don't get the reason for it. You can simply check your
> > patch via a tiny Lua chunk for 1.10, otherwise the patch and the test
> > are not necessary for the reasons I mentioned above.
>
> I rewrote test to simple lua chunk (see it below).
+1 here, it is much simpler.
The Lua-written test does not fail on 2.4, but it is not a problem: in
fact 2.4 is not affected by the problem (from a user point of view).
Re how to push: I would anyway push it from master downward, because the
fixed code may become alive (I mean, not dead) in a future and we'll
have the correct behaviour and the test. It is better than left it
incorrect just because it is dead in fact.
next prev parent reply other threads:[~2020-07-17 9:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 15:56 [Tarantool-patches] [PATCH 0/2] Msgpack wrong extension " Sergey Kaplun
2020-06-15 15:56 ` [Tarantool-patches] [PATCH 1/2] lib: update msgpuck library Sergey Kaplun
2020-06-15 15:56 ` [Tarantool-patches] [PATCH 2/2] msgpack: fix wrong mp_ext type in error message Sergey Kaplun
2020-07-14 15:46 ` Igor Munkin
2020-07-15 9:32 ` Sergey Kaplun
2020-07-15 15:21 ` Sergey Kaplun
2020-07-16 20:53 ` Igor Munkin
2020-07-17 8:35 ` Sergey Kaplun
2020-07-17 9:09 ` Alexander Turenko [this message]
2020-07-17 9:54 ` Sergey Kaplun
2020-07-17 9:23 ` sergos
2020-07-17 10:12 ` Igor Munkin
2020-07-17 11:02 ` Sergey Kaplun
2020-07-17 11:27 ` [Tarantool-patches] [PATCH 0/2] Msgpack wrong extension " Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200717090942.s5niw2k5ezrzlety@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=skaplun@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/2] msgpack: fix wrong mp_ext type in error message' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox