From: Igor Munkin <imun@tarantool.org>
To: Olga Arkhangelskaia <arkholga@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
Alexander Turenko <alexander.turenko@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 1/1] box: fixed box.info:memory()
Date: Fri, 17 Jul 2020 00:04:43 +0300 [thread overview]
Message-ID: <20200716210443.GQ5559@tarantool.org> (raw)
In-Reply-To: <1d010980-646d-3c73-bef7-1009fff6609c@tarantool.org>
Olya,
Thanks for the fixes! I checked the upstream. The patch LGTM except the
tiny nit.
Sasha, please proceed with the patch.
On 16.07.20, Olga Arkhangelskaia wrote:
<snipped>
> When box.info:memory is called, it has box.info table as a first
Typo: s/a first/the first/.
> argument (seehttps://www.lua.org/manual/5.1/manual.html#2.8). While
> printing the table, lbox_info_memory_call adds box.info.memory's fields
> to the box.info table. To avoid this effect and return just
> box.info.memory we put an empty table on the Lua stack at the beginning
> of the lbox_info_memory_call function. Instead adding fields to box.info
> table lbox_info_memory_call fills that empty table.
<snipped>
--
Best regards,
IM
next prev parent reply other threads:[~2020-07-16 21:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200629121118.21596-1-arkholga@tarantool.org>
2020-06-29 12:11 ` Olga Arkhangelskaia
2020-07-01 21:34 ` Igor Munkin
2020-07-02 10:01 ` Olga Arkhangelskaia
2020-07-09 1:08 ` Alexander Turenko
2020-07-09 13:57 ` Olga Arkhangelskaia
2020-07-15 14:40 ` Alexander Turenko
2020-07-16 17:56 ` Igor Munkin
2020-07-16 20:29 ` Olga Arkhangelskaia
2020-07-16 20:56 ` Alexander Turenko
2020-07-16 21:04 ` Igor Munkin [this message]
2020-07-17 6:38 ` Olga Arkhangelskaia
2020-07-01 21:34 ` [Tarantool-patches] [PATCH 0/1] fix box.info:memory() Igor Munkin
2020-07-09 1:08 ` Alexander Turenko
2020-07-09 14:02 ` Olga Arkhangelskaia
2020-07-16 18:16 ` Igor Munkin
2020-07-16 18:29 ` Alexander Turenko
2020-07-17 6:18 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200716210443.GQ5559@tarantool.org \
--to=imun@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=arkholga@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/1] box: fixed box.info:memory()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox