* [Tarantool-patches] [PATCH v1] Bump curl repository to 7.71.1 version @ 2020-07-16 15:10 Alexander V. Tikhonov 2020-07-16 18:02 ` Alexander Turenko 2020-07-17 11:09 ` Kirill Yukhin 0 siblings, 2 replies; 5+ messages in thread From: Alexander V. Tikhonov @ 2020-07-16 15:10 UTC (permalink / raw) To: Kirill Yukhin, Alexander Turenko; +Cc: tarantool-patches Check the new version. Closes #4698 --- Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4698-curl-7-71-1 Issue: https://github.com/tarantool/tarantool/issues/4698 third_party/curl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/third_party/curl b/third_party/curl index 9cd755e1d..12af024bc 160000 --- a/third_party/curl +++ b/third_party/curl @@ -1 +1 @@ -Subproject commit 9cd755e1d768bbf228e7c9faf223b7459f7e0105 +Subproject commit 12af024bc85606b14ffc415413a7e86e6bbee7eb -- 2.17.1 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Tarantool-patches] [PATCH v1] Bump curl repository to 7.71.1 version 2020-07-16 15:10 [Tarantool-patches] [PATCH v1] Bump curl repository to 7.71.1 version Alexander V. Tikhonov @ 2020-07-16 18:02 ` Alexander Turenko 2020-07-16 19:15 ` Alexander V. Tikhonov 2020-07-17 11:09 ` Kirill Yukhin 1 sibling, 1 reply; 5+ messages in thread From: Alexander Turenko @ 2020-07-16 18:02 UTC (permalink / raw) To: Alexander V. Tikhonov; +Cc: tarantool-patches > Bump curl repository to 7.71.1 version Nit: I would say that we update a submodule here (not a repository), because 'bump repository' looks as `git push` action for me. Please, add a prefix (I suggest 'build'). See [1] for example. > > Check the new version. To solve a problem, right? Please, clarify it or at least mention it. AFAIR, I described the security problem that is related for us in the issue (there are two security problems, but only one looks related to us). > > Closes #4698 > --- > > Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4698-curl-7-71-1 > Issue: https://github.com/tarantool/tarantool/issues/4698 > > third_party/curl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/third_party/curl b/third_party/curl > index 9cd755e1d..12af024bc 160000 > --- a/third_party/curl > +++ b/third_party/curl > @@ -1 +1 @@ > -Subproject commit 9cd755e1d768bbf228e7c9faf223b7459f7e0105 > +Subproject commit 12af024bc85606b14ffc415413a7e86e6bbee7eb Please, checkout the curl-7_71_1 tag, not the HEAD of curl-7_71_1-tarantool branch, which is for building using CMake. See [2] starting from words "Please, don't mix". [1]: https://github.com/tarantool/tarantool/commit/4c2d1eff29848cc2ed47cd1d3ca23152fed2e3b9 [2]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-July/018443.html ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Tarantool-patches] [PATCH v1] Bump curl repository to 7.71.1 version 2020-07-16 18:02 ` Alexander Turenko @ 2020-07-16 19:15 ` Alexander V. Tikhonov 2020-07-16 19:21 ` Alexander Turenko 0 siblings, 1 reply; 5+ messages in thread From: Alexander V. Tikhonov @ 2020-07-16 19:15 UTC (permalink / raw) To: Alexander Turenko; +Cc: tarantool-patches Hi Alexander, thanks for the clear instructions, I've made all the corrections as you suggested. On Thu, Jul 16, 2020 at 09:02:06PM +0300, Alexander Turenko wrote: > > Bump curl repository to 7.71.1 version > > Nit: I would say that we update a submodule here (not a repository), > because 'bump repository' looks as `git push` action for me. > > Please, add a prefix (I suggest 'build'). > > See [1] for example. > Rewrote in the style as you showed. > > > > Check the new version. > > To solve a problem, right? Please, clarify it or at least mention it. > AFAIR, I described the security problem that is related for us in the > issue (there are two security problems, but only one looks related to > us). > Sure, done. > > > > Closes #4698 > > --- > > > > Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4698-curl-7-71-1 > > Issue: https://github.com/tarantool/tarantool/issues/4698 > > > > third_party/curl | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/third_party/curl b/third_party/curl > > index 9cd755e1d..12af024bc 160000 > > --- a/third_party/curl > > +++ b/third_party/curl > > @@ -1 +1 @@ > > -Subproject commit 9cd755e1d768bbf228e7c9faf223b7459f7e0105 > > +Subproject commit 12af024bc85606b14ffc415413a7e86e6bbee7eb > > Please, checkout the curl-7_71_1 tag, not the HEAD of > curl-7_71_1-tarantool branch, which is for building using CMake. See [2] > starting from words "Please, don't mix". > > [1]: https://github.com/tarantool/tarantool/commit/4c2d1eff29848cc2ed47cd1d3ca23152fed2e3b9 > [2]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-July/018443.html Right, I've just forgot that OOS build is not in the trunk now. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Tarantool-patches] [PATCH v1] Bump curl repository to 7.71.1 version 2020-07-16 19:15 ` Alexander V. Tikhonov @ 2020-07-16 19:21 ` Alexander Turenko 0 siblings, 0 replies; 5+ messages in thread From: Alexander Turenko @ 2020-07-16 19:21 UTC (permalink / raw) To: Alexander V. Tikhonov; +Cc: tarantool-patches > > > Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4698-curl-7-71-1 > > > Issue: https://github.com/tarantool/tarantool/issues/4698 > > > > > > third_party/curl | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) I have no objections anymore. LGTM. CCed Kirill. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Tarantool-patches] [PATCH v1] Bump curl repository to 7.71.1 version 2020-07-16 15:10 [Tarantool-patches] [PATCH v1] Bump curl repository to 7.71.1 version Alexander V. Tikhonov 2020-07-16 18:02 ` Alexander Turenko @ 2020-07-17 11:09 ` Kirill Yukhin 1 sibling, 0 replies; 5+ messages in thread From: Kirill Yukhin @ 2020-07-17 11:09 UTC (permalink / raw) To: Alexander V. Tikhonov; +Cc: tarantool-patches, Alexander Turenko Hello, On 16 июл 18:10, Alexander V. Tikhonov wrote: > Check the new version. > > Closes #4698 > --- > > Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4698-curl-7-71-1 > Issue: https://github.com/tarantool/tarantool/issues/4698 I've checked your patch into 1.10, 2.3, 2.4 and master. -- Regards, Kirill Yukhin ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-07-17 11:09 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-07-16 15:10 [Tarantool-patches] [PATCH v1] Bump curl repository to 7.71.1 version Alexander V. Tikhonov 2020-07-16 18:02 ` Alexander Turenko 2020-07-16 19:15 ` Alexander V. Tikhonov 2020-07-16 19:21 ` Alexander Turenko 2020-07-17 11:09 ` Kirill Yukhin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox