From: Ilya Kosarev <i.kosarev@tarantool.org> To: imun@tarantool.org Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH] lua: panic on lua_gettop() negative return value Date: Thu, 16 Jul 2020 21:16:39 +0300 [thread overview] Message-ID: <20200716181639.1683-1-i.kosarev@tarantool.org> (raw) According to gh-4649 report it seems to be possible that we are getting segfault on empty diag in iproto_reply_error() due to negative count of dumped entries returned from port_lua_do_dump() in tx_process_call(). It can only happen due to lua_gettop() returning negative value in encode_lua_call(). This should not happen at all, so it is the reason to panic. Closes #4649 --- Branch: https://github.com/tarantool/tarantool/tree/i.kosarev/gh-4649-empty-diag-from-tx_process_call Issue: https://github.com/tarantool/tarantool/issues/4649 @ChangeLog: * Panic in case of critical problem: lua_gettop() returning negative value (gh-4649). src/box/lua/call.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/box/lua/call.c b/src/box/lua/call.c index ca871e077..82ca47cbe 100644 --- a/src/box/lua/call.c +++ b/src/box/lua/call.c @@ -361,6 +361,8 @@ encode_lua_call(lua_State *L) struct luaL_serializer *cfg = luaL_msgpack_default; int size = lua_gettop(port->L); + if (size < 0) + panic("lua_gettop() returned negative value"); for (int i = 1; i <= size; ++i) luamp_encode(port->L, cfg, &stream, i); port->size = size; -- 2.17.1
next reply other threads:[~2020-07-16 18:16 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-16 18:16 Ilya Kosarev [this message] 2020-07-17 8:34 ` sergos 2020-07-17 10:36 ` Igor Munkin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200716181639.1683-1-i.kosarev@tarantool.org \ --to=i.kosarev@tarantool.org \ --cc=imun@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH] lua: panic on lua_gettop() negative return value' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox