Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1] Bump curl repository to 7.71.1 version
Date: Thu, 16 Jul 2020 21:02:06 +0300	[thread overview]
Message-ID: <20200716180206.tamvh5y2qbbuxqnj@tkn_work_nb> (raw)
In-Reply-To: <b5fb66465c420ec3a0f642692d769ada6c76b573.1594912145.git.avtikhon@tarantool.org>

> Bump curl repository to 7.71.1 version

Nit: I would say that we update a submodule here (not a repository),
because 'bump repository' looks as `git push` action for me.

Please, add a prefix (I suggest 'build').

See [1] for example.

>
> Check the new version.

To solve a problem, right? Please, clarify it or at least mention it.
AFAIR, I described the security problem that is related for us in the
issue (there are two security problems, but only one looks related to
us).

> 
> Closes #4698
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4698-curl-7-71-1
> Issue: https://github.com/tarantool/tarantool/issues/4698
> 
>  third_party/curl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/third_party/curl b/third_party/curl
> index 9cd755e1d..12af024bc 160000
> --- a/third_party/curl
> +++ b/third_party/curl
> @@ -1 +1 @@
> -Subproject commit 9cd755e1d768bbf228e7c9faf223b7459f7e0105
> +Subproject commit 12af024bc85606b14ffc415413a7e86e6bbee7eb

Please, checkout the curl-7_71_1 tag, not the HEAD of
curl-7_71_1-tarantool branch, which is for building using CMake. See [2]
starting from words "Please, don't mix".

[1]: https://github.com/tarantool/tarantool/commit/4c2d1eff29848cc2ed47cd1d3ca23152fed2e3b9
[2]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-July/018443.html

  reply	other threads:[~2020-07-16 18:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-16 15:10 Alexander V. Tikhonov
2020-07-16 18:02 ` Alexander Turenko [this message]
2020-07-16 19:15   ` Alexander V. Tikhonov
2020-07-16 19:21     ` Alexander Turenko
2020-07-17 11:09 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200716180206.tamvh5y2qbbuxqnj@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=avtikhon@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v1] Bump curl repository to 7.71.1 version' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox