Re: [Tarantool-patches] [PATCH 0/2] Follow-up for "_session_settings" space

[Mergen Imeev <imeevma@tarantool.org>]

Hi! Thank you for the patches. See 2 comments below.

On Wed, Jul 08, 2020 at 02:47:16PM +0300, Roman Khabibov wrote:
1. Please write some description of the patch-set.

> @ChangeLog
> - Fix _session_settings name in error messages
> - Raname "sql_defer_foreign_keys" setting to
> "sql_defer_foreign_key_changes".
2. Please refer to the 'Code review procedure' on the Wiki for the
rules for writing ChangeLog correctly. It should be written on one
line and with the issue number.

> 
> Branch: https://github.com/tarantool/tarantool/tree/romanhabibov/gh-4732-ss-space
> Issue: https://github.com/tarantool/tarantool/issues/4732
> 
> Roman Khabibov (2):
>   sql: fix _session_settings name in error messages
>   sql: clarify "sql_defer_foreign_keys" setting name
> 
>  src/box/session_settings.c                |  10 +-
>  test/box/session_settings.result          | 108 +++++++++++-----------
>  test/box/session_settings.test.lua        |  86 ++++++++---------
>  test/sql/transitive-transactions.result   |   4 +-
>  test/sql/transitive-transactions.test.lua |   4 +-
>  5 files changed, 106 insertions(+), 106 deletions(-)
> 
> -- 
> 2.21.0 (Apple Git-122)
>