From: Cyrill Gorcunov <gorcunov@gmail.com> To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Cc: tml <tarantool-patches@dev.tarantool.org> Subject: [Tarantool-patches] [PATCH 2/4] qsync: drop txn_limbo_confirm_timeout Date: Tue, 14 Jul 2020 17:44:38 +0300 [thread overview] Message-ID: <20200714144440.551127-3-gorcunov@gmail.com> (raw) In-Reply-To: <20200714144440.551127-1-gorcunov@gmail.com> We already use replication_synchro_quorum in code, no need for this wrap. Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> --- src/box/box.cc | 2 +- src/box/txn_limbo.c | 11 ++--------- src/box/txn_limbo.h | 3 --- 3 files changed, 3 insertions(+), 13 deletions(-) diff --git a/src/box/box.cc b/src/box/box.cc index 884061a81..7a7befc32 100644 --- a/src/box/box.cc +++ b/src/box/box.cc @@ -959,7 +959,7 @@ box_clear_synchro_queue(void) return; /* Wait until pending confirmations/rollbacks reach us. */ - double timeout = 2 * txn_limbo_confirm_timeout(&txn_limbo); + double timeout = 2 * replication_synchro_timeout; double start_tm = fiber_time(); while (!txn_limbo_is_empty(&txn_limbo)) { if (fiber_time() - start_tm > timeout) diff --git a/src/box/txn_limbo.c b/src/box/txn_limbo.c index 9623b71cf..15dbe6515 100644 --- a/src/box/txn_limbo.c +++ b/src/box/txn_limbo.c @@ -173,7 +173,7 @@ txn_limbo_wait_complete(struct txn_limbo *limbo, struct txn_limbo_entry *entry) assert(txn_has_flag(txn, TXN_WAIT_SYNC)); double start_time = fiber_clock(); while (true) { - double deadline = start_time + txn_limbo_confirm_timeout(limbo); + double deadline = start_time + replication_synchro_timeout; bool cancellable = fiber_set_cancellable(false); double timeout = deadline - fiber_clock(); bool timed_out = fiber_cond_wait_timeout(&limbo->wait_cond, @@ -450,13 +450,6 @@ txn_limbo_ack(struct txn_limbo *limbo, uint32_t replica_id, int64_t lsn) } } -double -txn_limbo_confirm_timeout(struct txn_limbo *limbo) -{ - (void)limbo; - return replication_synchro_timeout; -} - /** * Waitpoint stores information about the progress of confirmation. * In the case of multimaster support, it will store a bitset @@ -516,7 +509,7 @@ txn_limbo_wait_confirm(struct txn_limbo *limbo) txn_on_rollback(tle->txn, &on_rollback); double start_time = fiber_clock(); while (true) { - double deadline = start_time + txn_limbo_confirm_timeout(limbo); + double deadline = start_time + replication_synchro_timeout; bool cancellable = fiber_set_cancellable(false); double timeout = deadline - fiber_clock(); int rc = fiber_cond_wait_timeout(&limbo->wait_cond, timeout); diff --git a/src/box/txn_limbo.h b/src/box/txn_limbo.h index 918db2263..8cfb490c3 100644 --- a/src/box/txn_limbo.h +++ b/src/box/txn_limbo.h @@ -232,9 +232,6 @@ txn_limbo_read_confirm(struct txn_limbo *limbo, int64_t lsn); void txn_limbo_read_rollback(struct txn_limbo *limbo, int64_t lsn); -double -txn_limbo_confirm_timeout(struct txn_limbo *limbo); - /** * Waiting for confirmation of all "sync" transactions * during confirm timeout or fail. -- 2.26.2
next prev parent reply other threads:[~2020-07-14 14:45 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-14 14:44 [Tarantool-patches] [PATCH 0/4] qsync: continue cooking the code Cyrill Gorcunov 2020-07-14 14:44 ` [Tarantool-patches] [PATCH 1/4] qsync: add missing functions descriptions Cyrill Gorcunov 2020-07-14 14:44 ` Cyrill Gorcunov [this message] 2020-07-14 14:44 ` [Tarantool-patches] [PATCH 3/4] qsync: txn_limbo_wait_complete -- fix type conversion Cyrill Gorcunov 2020-07-14 14:44 ` [Tarantool-patches] [PATCH 4/4] qsync: don't send negative timeouts into fiber_cond_wait_timeout Cyrill Gorcunov 2020-07-14 14:53 ` [Tarantool-patches] [PATCH v2 " Cyrill Gorcunov 2020-07-16 22:45 ` Vladislav Shpilevoy 2020-07-17 7:25 ` Cyrill Gorcunov 2020-07-17 20:03 ` Vladislav Shpilevoy 2020-07-17 20:33 ` Cyrill Gorcunov 2020-07-17 20:43 ` Cyrill Gorcunov 2020-07-20 19:28 ` [Tarantool-patches] [PATCH 0/4] qsync: continue cooking the code Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200714144440.551127-3-gorcunov@gmail.com \ --to=gorcunov@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 2/4] qsync: drop txn_limbo_confirm_timeout' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox