Re: [Tarantool-patches] [PATCH v1] test: replication/wal_rw_stress fix wait_cond

[Kirill Yukhin <kyukhin@tarantool.org>]

Hello,

On 14 июл 13:42, Alexander V. Tikhonov wrote:
> Found that on heavy loaded hosts the test tries to check replication
> downstream status when downstream structure is not ready and it fails
> with the error:
> 
> [017] --- replication/wal_rw_stress.result	Thu Jul  9 17:04:16 2020
> [017] +++ replication/wal_rw_stress.reject	Fri May  8 08:25:15 2020
> [017] @@ -75,7 +75,8 @@
> [017]      return box.info.replication[1].downstream.status ~= 'stopped' \
> [017]  end) or box.info
> [017]  ---
> [017] -- true
> [017] +- error: '[string "return test_run:wait_cond(function()         ..."]:1: attempt to
> [017] +    index field ''downstream'' (a nil value)'
> [017]  ...
> [017]  test_run:cmd("switch default")
> [017]  ---
> [017]
> 
> So the wait condition should start from the check of the downstream
> structure availability.
> 
> Follows up #4977
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4977-test-replication-wal_rw_stress
> Issue: https://github.com/tarantool/tarantool/issues/4977

LGTM.

I've checked your patch into 1.10, 2.3, 2.4 and master.

--
Regards, Kirill Yukhin