From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] serilaizer: check for recursive serialization
Date: Tue, 14 Jul 2020 13:40:27 +0300 [thread overview]
Message-ID: <20200714104027.GF296695@grain> (raw)
In-Reply-To: <20200714094533.GK5559@tarantool.org>
On Tue, Jul 14, 2020 at 12:45:33PM +0300, Igor Munkin wrote:
> >
> > Wait. The @idx stands for index in a table as far as I remember,
> > this just happen to hit when you're calling youself recursively
> > but @idx may be > SERIALIZER_CRITICAL_RECURSION_DEPTH for nonrecursive
> > calls as well.
>
> I guess you've just misread this part: @idx is just a guest stack slot
> where Lua object being serialized is stored. If I get your concerns
> right, you're talking about the following case:
Yes, you're right. Thanks, Igor! I don't have strong preference here
on how to handle the case. Thus
Reviewed-by: Cyrill Gorcunov <gorcunov@gmail.com>
next prev parent reply other threads:[~2020-07-14 10:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 12:01 Roman Khabibov
2020-07-10 12:29 ` Cyrill Gorcunov
2020-07-14 9:45 ` Igor Munkin
2020-07-14 10:40 ` Cyrill Gorcunov [this message]
2020-09-14 14:43 ` Roman Khabibov
2020-09-14 16:06 ` Cyrill Gorcunov
2020-09-16 7:29 ` Igor Munkin
2020-09-30 21:49 ` Roman Khabibov
2020-10-01 14:40 ` Igor Munkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714104027.GF296695@grain \
--to=gorcunov@gmail.com \
--cc=imun@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] serilaizer: check for recursive serialization' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox