From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9D624445320 for ; Tue, 14 Jul 2020 13:40:32 +0300 (MSK) Received: by mail-lj1-f194.google.com with SMTP id r19so21814328ljn.12 for ; Tue, 14 Jul 2020 03:40:32 -0700 (PDT) Date: Tue, 14 Jul 2020 13:40:27 +0300 From: Cyrill Gorcunov Message-ID: <20200714104027.GF296695@grain> References: <20200710120109.91675-1-roman.habibov@tarantool.org> <20200710122958.GF1999@grain> <20200714094533.GK5559@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200714094533.GK5559@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] serilaizer: check for recursive serialization List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org On Tue, Jul 14, 2020 at 12:45:33PM +0300, Igor Munkin wrote: > > > > Wait. The @idx stands for index in a table as far as I remember, > > this just happen to hit when you're calling youself recursively > > but @idx may be > SERIALIZER_CRITICAL_RECURSION_DEPTH for nonrecursive > > calls as well. > > I guess you've just misread this part: @idx is just a guest stack slot > where Lua object being serialized is stored. If I get your concerns > right, you're talking about the following case: Yes, you're right. Thanks, Igor! I don't have strong preference here on how to handle the case. Thus Reviewed-by: Cyrill Gorcunov