From: Kirill Yukhin <kyukhin@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/1] test: fix flaky qsync_basic.test.lua
Date: Mon, 13 Jul 2020 12:07:18 +0300 [thread overview]
Message-ID: <20200713090718.njhfzedyd3x56zwd@tarantool.org> (raw)
In-Reply-To: <094d9d56fcd71a01cd3a9467e81a18fd8608a032.1594486881.git.v.shpilevoy@tarantool.org>
Hello,
On 11 июл 19:01, Vladislav Shpilevoy wrote:
> In one of the test cases 2 fibers were started making a
> transaction. In the first fiber the transaction was rolled back,
> and the second fiber was expected to do the same.
>
> It did rollback too, but not always immediately after the first
> one. Because the first fiber needed not just do rollback right
> away, but write a ROLLBACK entry into WAL before applying the
> rollback to all next transactions. This led to a yield, during
> which it was possible to observe the second fiber not dead yet.
>
> The patch makes the test explicitly wait for the fibers death.
>
> Closes #5162
> ---
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-5162-flaky-qsync_basic
> Issue: https://github.com/tarantool/tarantool/issues/5162
LGTM.
I've checked your patch into master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2020-07-13 9:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-11 17:01 Vladislav Shpilevoy
2020-07-13 8:35 ` Cyrill Gorcunov
2020-07-13 9:07 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713090718.njhfzedyd3x56zwd@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/1] test: fix flaky qsync_basic.test.lua' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox