From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/1] recovery: handle local sync txns during recovery
Date: Mon, 13 Jul 2020 12:02:05 +0300 [thread overview]
Message-ID: <20200713090205.GE296695@grain> (raw)
In-Reply-To: <d95084d7f030086ec574cb8906dca3c8a22e9c0f.1594487098.git.v.shpilevoy@tarantool.org>
On Sat, Jul 11, 2020 at 07:05:19PM +0200, Vladislav Shpilevoy wrote:
> Recovery uses txn_commit_async() so as not to block the recovery
> process when a synchronous transaction is met. They are either
> committed later when CONFIRM is read, or stay in the limbo after
> recovery.
>
> However txn_commit_async() assumed it is used for remote
> transactions only, and had some assertions about that. One of them
> crashed in case master restarted and had any synchronous
> transaction in WAL.
>
> The patch makes txn_commit_async() not assume anything about
> transaction's origin.
>
> Closes #5163
I might be missing something due to lack of strong understanding
of our current qsync implementation. Still the patch looks reasonable
and simple enough. Thus
Reviewed-by: Cyrill Gorcunov <gorcunov@gmail.com>
next prev parent reply other threads:[~2020-07-13 9:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-11 17:05 Vladislav Shpilevoy
2020-07-13 9:02 ` Cyrill Gorcunov [this message]
2020-07-13 9:41 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713090205.GE296695@grain \
--to=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/1] recovery: handle local sync txns during recovery' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox