From: Nikita Pettik <korablev@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2/2] sql: clarify "sql_defer_foreign_keys" setting name
Date: Sun, 12 Jul 2020 22:11:00 +0000 [thread overview]
Message-ID: <20200712221100.GA13229@tarantool.org> (raw)
In-Reply-To: <d19f7068-1668-1a99-70db-78d05ee25141@tarantool.org>
On 12 Jul 17:31, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patch!
>
> See 3 comments below.
>
> On 08.07.2020 13:47, Roman Khabibov wrote:
> > Raname "sql_defer_foreign_keys" setting to
> > "sql_defer_foreign_key_changes".
>
> 1. 'Raname' -> 'Rename'.
>
> 2. I think the new name is worse. Changes are done immediately.
> You can't defer them. The flag means defer the foreign key checks,
> not changes. To allow temporary inconsistency if a transaction needs
> it, but still check FKs when it will commit.
Agree, this renaming looks pointless and even misleading.
I see it was suggested by Peter, but I don't see enough
arguments to change the name. Please, reject the patch.
> > Follow up #4511
> >
> > @TarantoolBot document
> > Title: sql_defer_foreign_keys in _space_settings
>
> 3. There is no such space '_space_settings'.
>
> > Rename "sql_defer_foreign_keys" setting to
> > "sql_defer_foreign_key_changes".
next prev parent reply other threads:[~2020-07-12 22:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 11:47 [Tarantool-patches] [PATCH 0/2] Follow-up for "_session_settings" space Roman Khabibov
2020-07-08 11:47 ` [Tarantool-patches] [PATCH 1/2] sql: fix _session_settings name in error messages Roman Khabibov
2020-07-14 16:07 ` Mergen Imeev
2020-10-08 16:17 ` Roman Khabibov
2020-11-03 20:31 ` Mergen Imeev
2020-11-10 16:12 ` Roman Khabibov
2020-07-08 11:47 ` [Tarantool-patches] [PATCH 2/2] sql: clarify "sql_defer_foreign_keys" setting name Roman Khabibov
2020-07-12 15:31 ` Vladislav Shpilevoy
2020-07-12 22:11 ` Nikita Pettik [this message]
2020-07-14 16:22 ` Mergen Imeev
2020-07-14 16:01 ` [Tarantool-patches] [PATCH 0/2] Follow-up for "_session_settings" space Mergen Imeev
2020-11-26 9:51 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200712221100.GA13229@tarantool.org \
--to=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/2] sql: clarify "sql_defer_foreign_keys" setting name' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox