From: Kirill Yukhin <kyukhin@tarantool.org>
To: imeevma@tarantool.org
Cc: yaroslav.dynnikov@tarantool.org, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 1/1] luarock: change a way to create manifest
Date: Fri, 10 Jul 2020 11:28:59 +0300 [thread overview]
Message-ID: <20200710082859.7jlbcsm4ukzvozxy@tarantool.org> (raw)
In-Reply-To: <3cdf11659eb18f79faecb65f4cbe25022a8d205e.1594312926.git.imeevma@gmail.com>
Hello,
On 09 июл 19:45, imeevma@tarantool.org wrote:
> Whenever a rock is installed it's being added to the repository
> manifest. And if a manifest doesn't exist yet, luarocks creates
> one by scanning the directory.
>
> It causes a problem when *.all.rock with dependencies is installed
> into an empty directory. Luarocks unpacks the all.rock before
> installing dependencies, and it's modules are captured during
> manifest creation. After the installation finishes, luarocks adds
> the all.rock to the manifest once again (now intentionally),
> detects collision of module names and renames them uniquely, like
> "cartridge_1_2_0_1". As a result, "require()" function doesn't
> work.
>
> This patch changes the way of manifest creation: instead of
> scanning repo luarocks creates an empty one.
>
> Closes tarantool/tarantool#4704
I've checked your patch into tarantool/luarocks's tarantool-1.7
branch and bumped a new version in 1.10 branch.
--
Regards, Kirill Yukhin
next prev parent reply other threads:[~2020-07-10 8:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 16:45 imeevma
2020-07-09 16:50 ` Yaroslav Dynnikov
2020-07-09 17:13 ` Leonid Vasiliev
2020-07-10 8:28 ` Kirill Yukhin [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-07-09 15:51 imeevma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200710082859.7jlbcsm4ukzvozxy@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=yaroslav.dynnikov@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 1/1] luarock: change a way to create manifest' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox