From: Kirill Yukhin <kyukhin@tarantool.org>
To: Ilya Kosarev <i.kosarev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] xlog: make log directory if needed
Date: Thu, 9 Jul 2020 11:39:05 +0300 [thread overview]
Message-ID: <20200709083905.hknbnpc4ibo7t544@tarantool.org> (raw)
In-Reply-To: <20200629124419.23922-1-i.kosarev@tarantool.org>
Hello,
On 29 июн 15:44, Ilya Kosarev wrote:
> Tarantool's box.backup.start() returns the list of files needed to
> successfully run new instance. The problem was that it doesn't include
> empty indexes log directories. This means that after starting the
> instance using backed up files and inserting something into previously
> empty index we could run into log file creation error for example on
> box.snapshot() call. Now this is not a problem as far as according
> directories are created if needed.
>
> Closes #5090
> ---
> Branch: https://github.com/tarantool/tarantool/tree/i.kosarev/gh-5027-fix-tuple-fields-nullability
Wrong.
> Issue: https://github.com/tarantool/tarantool/issues/5027
Wrong.
>
> @ChangeLog:
> * Create missing folders for vinyl spaces and indexes if needed to
> avoid confusing fails of tarantool started from backup.
Need to mention an issue in brackets: (gh-5090).
Otherwise LGTM.
Fixed and checked into 1.10, 2.3, 2.4 and master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2020-07-09 8:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 12:44 Ilya Kosarev
2020-06-29 12:48 ` Cyrill Gorcunov
2020-06-29 12:49 ` Cyrill Gorcunov
2020-06-30 10:19 ` [Tarantool-patches] [PATCH v2] " Ilya Kosarev
2020-06-30 11:17 ` Cyrill Gorcunov
2020-07-09 8:39 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200709083905.hknbnpc4ibo7t544@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=i.kosarev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] xlog: make log directory if needed' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox