Tarantool development patches archive
 help / color / mirror / Atom feed
From: Nikita Pettik <korablev@tarantool.org>
To: Mergen Imeev <imeevma@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v3 4/8] sql: replace ApplyType by CheckType for IN operator
Date: Mon, 6 Jul 2020 22:06:25 +0000	[thread overview]
Message-ID: <20200706220625.GD22427@tarantool.org> (raw)
In-Reply-To: <20200705142851.GB135859@tarantool.org>

On 05 Jul 17:28, Mergen Imeev wrote:
> On Mon, Jun 29, 2020 at 12:56:30PM +0000, Nikita Pettik wrote:
> > On 25 Jun 18:17, imeevma@tarantool.org wrote:
> > > index f7681640e..a2147b0e8 100755
> > > --- a/test/sql-tap/in3.test.lua
> > > +++ b/test/sql-tap/in3.test.lua
> > > @@ -1,6 +1,6 @@
> > >  #!/usr/bin/env tarantool
> > >  test = require("sqltester")
> > > -test:plan(29)
> > > +test:plan(28)
> > >  
> > >  --!./tcltestrunner.lua
> > >  -- 2007 November 29
> > > @@ -322,18 +322,6 @@ test:do_test(
> > >          -- </in3-3.2>
> > >      })
> > >  
> > > -test:do_test(
> > > -    "in3-3.3",
> > > -    function()
> > > -        -- Logically, numeric affinity is applied to both sides before
> > > -        -- the comparison, but index can't be used.
> > > -        return exec_neph(" SELECT x IN (SELECT b FROM t1) FROM t2 ")
> > > -    end, {
> > > -        -- <in3-3.3>
> > > -        1, true
> > > -        -- </in3-3.3>
> > > -    })
> > > -
> > 
> > I'd rather not drop this test. It's about scalar-numeric types
> > interaction. Mb it is not the most suitable place for such test,
> > but make sure this scenario is covered somewhere else.
> > 
> I added a few tests with SCALARS in 'sql: remove implicit
> cast for comparison' commit. However, there is a lot
> problems with SCALARS at the moment.

Давай с этим что-то делать. Проблемы где-то описаны? Если нет,
давай подробно разберем и заведем тикет(ы). Иначе это звучит как
"idgs потом кто-нибудь это разгребет". В тикете 4230 есть
пункт про скаляр, но мы почему-то обходим его, оставляя
проблему as is.
 
> > The rest is OK as obvious.
> > 

  reply	other threads:[~2020-07-06 22:06 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-25 15:17 [Tarantool-patches] [PATCH v3 0/8] Remove implicit cast imeevma
2020-06-25 15:17 ` [Tarantool-patches] [PATCH v3 1/8] sql: introduce mem_set_double() imeevma
2020-06-28 13:31   ` Nikita Pettik
2020-07-06 14:02     ` Nikita Pettik
2020-06-25 15:17 ` [Tarantool-patches] [PATCH v3 2/8] sql: change implicit cast for assignment imeevma
2020-06-30 11:50   ` Nikita Pettik
2020-07-05 14:26     ` Mergen Imeev
2020-07-06 21:27       ` Nikita Pettik
2020-07-07  9:29         ` Mergen Imeev
2020-07-07 15:35           ` Nikita Pettik
2020-07-10 10:49           ` Nikita Pettik
2020-06-25 15:17 ` [Tarantool-patches] [PATCH v3 3/8] sql: remove mem_apply_type() from OP_MakeRecord imeevma
2020-06-25 15:17 ` [Tarantool-patches] [PATCH v3 4/8] sql: replace ApplyType by CheckType for IN operator imeevma
2020-06-29 12:56   ` Nikita Pettik
2020-07-05 14:28     ` Mergen Imeev
2020-07-06 22:06       ` Nikita Pettik [this message]
2020-07-07 11:26         ` Mergen Imeev
2020-07-07 16:29           ` Nikita Pettik
2020-06-25 15:17 ` [Tarantool-patches] [PATCH v3 5/8] sql: remove mem_apply_type() from OP_MustBeInt imeevma
2020-06-29 13:29   ` Nikita Pettik
2020-07-05 14:29     ` Mergen Imeev
2020-06-25 15:17 ` [Tarantool-patches] [PATCH v3 6/8] sql: remove implicit cast for comparison imeevma
2020-06-29 23:51   ` Nikita Pettik
2020-07-05 14:47     ` Mergen Imeev
2020-07-06 23:11       ` Nikita Pettik
2020-06-25 15:17 ` [Tarantool-patches] [PATCH v3 7/8] sql: remove unused functions imeevma
2020-06-29 23:52   ` Nikita Pettik
2020-07-05 14:50     ` Mergen Imeev
2020-06-25 15:17 ` [Tarantool-patches] [PATCH v3 8/8] sql: show value and its type in type mismatch error imeevma
2020-06-30  0:22   ` Nikita Pettik
2020-07-05 15:03     ` Mergen Imeev
2020-07-06 21:44       ` Nikita Pettik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200706220625.GD22427@tarantool.org \
    --to=korablev@tarantool.org \
    --cc=imeevma@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v3 4/8] sql: replace ApplyType by CheckType for IN operator' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox