From: Nikita Pettik <korablev@tarantool.org> To: Mergen Imeev <imeevma@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH v3 8/8] sql: show value and its type in type mismatch error Date: Mon, 6 Jul 2020 21:44:22 +0000 [thread overview] Message-ID: <20200706214422.GC22427@tarantool.org> (raw) In-Reply-To: <20200705150317.GF135859@tarantool.org> On 05 Jul 18:03, Mergen Imeev wrote: > My answers and diff below. > > On Tue, Jun 30, 2020 at 12:22:32AM +0000, Nikita Pettik wrote: > > On 25 Jun 18:17, imeevma@tarantool.org wrote: > > > After this patch value and its type will be shown in description > > > of type mismatch error > > > > Какие цели преследует этот патч? Зачем мы это делаем? > > Диф то на 1.5 кслок. > It is just a refactoring. It can be dropped. Хороший аргумент, добавить нечего. > > > diff --git a/test/sql-tap/gh-3809-implicit-cast-assignment.test.lua b/test/sql-tap/gh-3809-implicit-cast-assignment.test.lua > > > index a1809b3cb..f1edfa0f6 100755 > > > --- a/test/sql-tap/gh-3809-implicit-cast-assignment.test.lua > > > +++ b/test/sql-tap/gh-3809-implicit-cast-assignment.test.lua > > > @@ -28,7 +28,7 @@ test:do_catchsql_test( > > > [[ > > > INSERT INTO ti(i) VALUES (100000000000000000000000000000000.1) > > > ]], { > > > - 1, "Type mismatch: can not convert 1.0e+32 to integer" > > > + 1, "Type mismatch: can not convert '1.0e+32' (type: real) to integer" > > > }) > > > > Я бы может еще кавычки вокруг чиселок/буленов не добавлял, но это > > в принципе мелочь - тип то печатается. > > > I think it is better as it is now since in some cases > STRING value and BOOLEAN values look the same. В смысле? Булеан без кавычек, стринг - всегда в кавычках. Но как хочешь, тут настаивать не буду. > > В остальном - ОК. > > Diff: > > diff --git a/src/box/sql/vdbemem.c b/src/box/sql/vdbemem.c > index 32f4ae0b6..7cff881c0 100644 > --- a/src/box/sql/vdbemem.c > +++ b/src/box/sql/vdbemem.c > @@ -1163,6 +1163,10 @@ sqlValueText(sql_value * pVal) > return valueToText(pVal); > } > > +enum { > + DIAG_STR_LEN_MAX = 80, Но это же не длина диага. Не сильно лучше получилось. Давай что-нибудь в духи SQL_VALUE_DIAG_LEN_MAX и комментарий что это такое и почему 80.. > +}; > + > const char * > sql_value_to_diag_str(sql_value *value) > { > @@ -1172,7 +1176,7 @@ sql_value_to_diag_str(sql_value *value) > char *str = (char *)sqlValueText(value); > if (str == NULL) > return "NULL"; > - if (strlen(str) < 80) > + if (strlen(str) < DIAG_STR_LEN_MAX) > return tt_sprintf("'%s' (type: %s)", str, type); > return tt_sprintf("'%.80s...' (type: %s)", str, type); У тебя в принте осталась эта константа. Посмотри на магию %.*s >
prev parent reply other threads:[~2020-07-06 21:44 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-25 15:17 [Tarantool-patches] [PATCH v3 0/8] Remove implicit cast imeevma 2020-06-25 15:17 ` [Tarantool-patches] [PATCH v3 1/8] sql: introduce mem_set_double() imeevma 2020-06-28 13:31 ` Nikita Pettik 2020-07-06 14:02 ` Nikita Pettik 2020-06-25 15:17 ` [Tarantool-patches] [PATCH v3 2/8] sql: change implicit cast for assignment imeevma 2020-06-30 11:50 ` Nikita Pettik 2020-07-05 14:26 ` Mergen Imeev 2020-07-06 21:27 ` Nikita Pettik 2020-07-07 9:29 ` Mergen Imeev 2020-07-07 15:35 ` Nikita Pettik 2020-07-10 10:49 ` Nikita Pettik 2020-06-25 15:17 ` [Tarantool-patches] [PATCH v3 3/8] sql: remove mem_apply_type() from OP_MakeRecord imeevma 2020-06-25 15:17 ` [Tarantool-patches] [PATCH v3 4/8] sql: replace ApplyType by CheckType for IN operator imeevma 2020-06-29 12:56 ` Nikita Pettik 2020-07-05 14:28 ` Mergen Imeev 2020-07-06 22:06 ` Nikita Pettik 2020-07-07 11:26 ` Mergen Imeev 2020-07-07 16:29 ` Nikita Pettik 2020-06-25 15:17 ` [Tarantool-patches] [PATCH v3 5/8] sql: remove mem_apply_type() from OP_MustBeInt imeevma 2020-06-29 13:29 ` Nikita Pettik 2020-07-05 14:29 ` Mergen Imeev 2020-06-25 15:17 ` [Tarantool-patches] [PATCH v3 6/8] sql: remove implicit cast for comparison imeevma 2020-06-29 23:51 ` Nikita Pettik 2020-07-05 14:47 ` Mergen Imeev 2020-07-06 23:11 ` Nikita Pettik 2020-06-25 15:17 ` [Tarantool-patches] [PATCH v3 7/8] sql: remove unused functions imeevma 2020-06-29 23:52 ` Nikita Pettik 2020-07-05 14:50 ` Mergen Imeev 2020-06-25 15:17 ` [Tarantool-patches] [PATCH v3 8/8] sql: show value and its type in type mismatch error imeevma 2020-06-30 0:22 ` Nikita Pettik 2020-07-05 15:03 ` Mergen Imeev 2020-07-06 21:44 ` Nikita Pettik [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200706214422.GC22427@tarantool.org \ --to=korablev@tarantool.org \ --cc=imeevma@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v3 8/8] sql: show value and its type in type mismatch error' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox