From: Nikita Pettik <korablev@tarantool.org>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v3 1/8] sql: introduce mem_set_double()
Date: Mon, 6 Jul 2020 14:02:12 +0000 [thread overview]
Message-ID: <20200706140211.GA22427@tarantool.org> (raw)
In-Reply-To: <20200628133131.GA23521@tarantool.org>
On 28 Jun 13:31, Nikita Pettik wrote:
> On 25 Jun 18:17, imeevma@tarantool.org wrote:
> > The mem_set_double () function is used to properly set MEM as
> > containing DOUBLE value.
>
> Nit: it has been introduced a long ago (sqlVdbeMemSetDouble()).
> You refactor it and use in several other places.
>
> LGTM
>
I've fixed a bit commit message and pushed to master as trivial.
sql: refactor sqlVdbeMemSetDouble()
sqlVdbeMemSetDouble() function is used to properly set double value to
VDBE memory cell. Let's refactor it according to our codestyle and
rename it to mem_set_double() since we are going to use it instead of
raw mem's value modification.
next prev parent reply other threads:[~2020-07-06 14:02 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 15:17 [Tarantool-patches] [PATCH v3 0/8] Remove implicit cast imeevma
2020-06-25 15:17 ` [Tarantool-patches] [PATCH v3 1/8] sql: introduce mem_set_double() imeevma
2020-06-28 13:31 ` Nikita Pettik
2020-07-06 14:02 ` Nikita Pettik [this message]
2020-06-25 15:17 ` [Tarantool-patches] [PATCH v3 2/8] sql: change implicit cast for assignment imeevma
2020-06-30 11:50 ` Nikita Pettik
2020-07-05 14:26 ` Mergen Imeev
2020-07-06 21:27 ` Nikita Pettik
2020-07-07 9:29 ` Mergen Imeev
2020-07-07 15:35 ` Nikita Pettik
2020-07-10 10:49 ` Nikita Pettik
2020-06-25 15:17 ` [Tarantool-patches] [PATCH v3 3/8] sql: remove mem_apply_type() from OP_MakeRecord imeevma
2020-06-25 15:17 ` [Tarantool-patches] [PATCH v3 4/8] sql: replace ApplyType by CheckType for IN operator imeevma
2020-06-29 12:56 ` Nikita Pettik
2020-07-05 14:28 ` Mergen Imeev
2020-07-06 22:06 ` Nikita Pettik
2020-07-07 11:26 ` Mergen Imeev
2020-07-07 16:29 ` Nikita Pettik
2020-06-25 15:17 ` [Tarantool-patches] [PATCH v3 5/8] sql: remove mem_apply_type() from OP_MustBeInt imeevma
2020-06-29 13:29 ` Nikita Pettik
2020-07-05 14:29 ` Mergen Imeev
2020-06-25 15:17 ` [Tarantool-patches] [PATCH v3 6/8] sql: remove implicit cast for comparison imeevma
2020-06-29 23:51 ` Nikita Pettik
2020-07-05 14:47 ` Mergen Imeev
2020-07-06 23:11 ` Nikita Pettik
2020-06-25 15:17 ` [Tarantool-patches] [PATCH v3 7/8] sql: remove unused functions imeevma
2020-06-29 23:52 ` Nikita Pettik
2020-07-05 14:50 ` Mergen Imeev
2020-06-25 15:17 ` [Tarantool-patches] [PATCH v3 8/8] sql: show value and its type in type mismatch error imeevma
2020-06-30 0:22 ` Nikita Pettik
2020-07-05 15:03 ` Mergen Imeev
2020-07-06 21:44 ` Nikita Pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200706140211.GA22427@tarantool.org \
--to=korablev@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v3 1/8] sql: introduce mem_set_double()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox