From: Kirill Yukhin <kyukhin@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] applier: fix tx boundary check for half-applied txns
Date: Mon, 6 Jul 2020 09:33:59 +0300 [thread overview]
Message-ID: <20200706063359.fp3f3dvjk3wd2dja@tarantool.org> (raw)
In-Reply-To: <20200705115749.45407-1-sergepetrenko@tarantool.org>
Hello,
On 05 июл 14:57, Serge Petrenko wrote:
> In case there are 2 "new" instances, running tarantool 2.2+,
> master and replica, and one "old" instance, running an earlier tarantool
> version, in a full-mesh cluster, it may happen that the "new" replica
> receives part of a tx from an "old" instance, and the remaining part
> from a "new" instance.
>
> Since "new" instances preserve tx boundaries, "new" replica would skip
> the tx remains assuming it has already applied the full tx if it has
> applied the first tx row. This leads to gaps in "new" replica's WAL and
> to skipping the remaining part of the tx forever.
>
> Fix this behaviour to apply the full tx even if it's beginning is
> already applied in mixed clusters.
>
> Closes #5125
> ---
>
> https://github.com/tarantool/tarantool/issues/5125
> https://github.com/tarantool/tarantool/tree/sp/gh-5125-applier-tx-boundaries
LGTM.
I've checked your patch into 2.3, 2.4 and master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2020-07-06 6:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-05 11:57 Serge Petrenko
2020-07-05 16:11 ` Vladislav Shpilevoy
2020-07-06 6:33 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200706063359.fp3f3dvjk3wd2dja@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] applier: fix tx boundary check for half-applied txns' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox