From: Alexander Turenko <alexander.turenko@tarantool.org>
To: "Илья Конюхов" <runsfor@gmail.com>
Cc: tarantool-patches@dev.tarantool.org,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 1/2] feedback: determine runtime platform info
Date: Sun, 5 Jul 2020 05:14:13 +0300 [thread overview]
Message-ID: <20200705021413.s7jv7ugavv53vqek@tkn_work_nb> (raw)
In-Reply-To: <20200701001608.roz3fgqapgyqsonf@tkn_work_nb>
On Wed, Jul 01, 2020 at 03:16:10AM +0300, Alexander Turenko wrote:
> > +local function fill_in_platform_info(feedback)
> > + feedback.os = jit.os
> > + feedback.arch = jit.arch
> > + feedback.is_docker = detect_docker_environment()
> > +end
>
> Platform information may be grouped into its own category.
>
> Nit: I would choose more English friendly name for the 'is_docker'
> property. Say, 'dockerized' or at least 'is_under_docker'.
Whether you'll agree with grouping and renaming or not, the patch LGTM.
next prev parent reply other threads:[~2020-07-05 2:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 8:35 [Tarantool-patches] [PATCH 0/2] Extend feedback module report Ilya Konyukhov
2020-06-05 8:35 ` [Tarantool-patches] [PATCH 1/2] feedback: determine runtime platform info Ilya Konyukhov
2020-06-07 16:45 ` Vladislav Shpilevoy
2020-06-09 23:05 ` Илья Конюхов
2020-06-11 19:32 ` Vladislav Shpilevoy
2020-07-01 0:16 ` Alexander Turenko
2020-07-05 2:14 ` Alexander Turenko [this message]
2020-06-05 8:35 ` [Tarantool-patches] [PATCH 2/2] feedback: collect db engines and index features Ilya Konyukhov
2020-06-07 16:45 ` Vladislav Shpilevoy
2020-06-09 23:06 ` Илья Конюхов
2020-06-11 19:32 ` Vladislav Shpilevoy
2020-06-17 8:59 ` Илья Конюхов
2020-06-17 22:53 ` Vladislav Shpilevoy
2020-06-18 15:42 ` Илья Конюхов
2020-06-18 23:02 ` Vladislav Shpilevoy
2020-06-19 14:01 ` Илья Конюхов
2020-06-19 23:49 ` Vladislav Shpilevoy
2020-06-22 8:55 ` Илья Конюхов
2020-07-01 0:15 ` Alexander Turenko
2020-07-03 12:05 ` Илья Конюхов
2020-07-05 2:10 ` Alexander Turenko
2020-06-23 21:23 ` [Tarantool-patches] [PATCH 0/2] Extend feedback module report Vladislav Shpilevoy
2020-07-13 13:47 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200705021413.s7jv7ugavv53vqek@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=runsfor@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/2] feedback: determine runtime platform info' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox