Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1] build: fix static build w/ dockerfile with cmake
Date: Fri, 3 Jul 2020 14:32:30 +0300	[thread overview]
Message-ID: <20200703113230.kp3jnbzt5lsjk6lc@tkn_work_nb> (raw)
In-Reply-To: <e13d89eb48565441454348ce8ae816a2cf88307e.1593436970.git.avtikhon@tarantool.org>

> Closes #5019

Since it is now out of the patchset, where curl is build using cmake, it
should be clarified that the problem only appears after switching curl
to build using cmake.

> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-5019-findopenssl-dockerfile
> Issue: https://github.com/tarantool/tarantool/issues/5019
> 
>  Dockerfile.staticbuild | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Dockerfile.staticbuild b/Dockerfile.staticbuild
> index 253f2d5e9..cb6c12e94 100644
> --- a/Dockerfile.staticbuild
> +++ b/Dockerfile.staticbuild
> @@ -86,6 +86,8 @@ RUN set -x && \
>           -DOPENSSL_USE_STATIC_LIBS=ON \
>           -DOPENSSL_ROOT_DIR=/usr/local \
>           . && \
> +    sed 's%#define%#[\\t ]*define%g' -i \
> +        /usr/share/cmake/Modules/FindOpenSSL.cmake && \
>      make -j && make install

In fact it means that we'll not actually support cmake 2.8, not even
3.0 / 3.1, but only cmake since v3.1.1-1-gc5d9a8283c.

Can we pass custom CMAKE_MODULE_PATH with our cmake/ directory to curl?

  reply	other threads:[~2020-07-03 11:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-29 13:23 Alexander V. Tikhonov
2020-07-03 11:32 ` Alexander Turenko [this message]
2020-07-10  9:26   ` Alexander V. Tikhonov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200703113230.kp3jnbzt5lsjk6lc@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=avtikhon@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v1] build: fix static build w/ dockerfile with cmake' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox