From: Kirill Yukhin <kyukhin@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: Oleg Piskunov <o.piskunov@tarantool.org>,
tarantool-patches@dev.tarantool.org,
Alexander Turenko <alexander.turenko@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 1/7] build: static build needs more cleanup in sources
Date: Fri, 3 Jul 2020 14:13:22 +0300 [thread overview]
Message-ID: <20200703111322.umrmzpgqqg54fo3i@tarantool.org> (raw)
In-Reply-To: <b07b25b57cb46c9d1c618ee3c1bf9189b77c1525.1590503508.git.avtikhon@tarantool.org>
Hello,
n 26 май 17:42, Alexander V. Tikhonov wrote:
> Building Tarantool sources on make command run may fail with:
>
> [ 10%] make[2]: *** [test/small] Error 1
> [ 10%] make[1]: *** [test/CMakeFiles/symlink_small_tests.dir/all] Error 2
> make[1]: *** Waiting for unfinished jobs....
>
> The root cause of the issue that Dockerfile.staticbuild
> uses local copy of sources:
>
> COPY . /tarantool
>
> Which may have broken links in tests, like:
>
> $ ls -al test
> ...
> luajit-tap -> /<wrong path>/third_party/luajit/test
> small -> /<wrong path>/src/lib/small/test/
I've checked your patch into 1.10, 2.3, 2.4 and master.
--
Regards, Kirill Yukhin
next prev parent reply other threads:[~2020-07-03 11:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 14:42 [Tarantool-patches] [PATCH v2 0/7] Implement OOS build Alexander V. Tikhonov
2020-05-26 14:42 ` [Tarantool-patches] [PATCH v2 1/7] build: static build needs more cleanup in sources Alexander V. Tikhonov
2020-06-26 13:51 ` Alexander Turenko
2020-07-03 11:13 ` Kirill Yukhin [this message]
2020-05-26 14:42 ` [Tarantool-patches] [PATCH v2 2/7] build: fix static build w/ dockerfile with cmake Alexander V. Tikhonov
2020-05-26 14:42 ` [Tarantool-patches] [PATCH v2 3/7] build: enable cmake in curl build Alexander V. Tikhonov
2020-05-26 14:42 ` [Tarantool-patches] [PATCH v2 4/7] Fix curl repository for out-of-source build Alexander V. Tikhonov
2020-05-26 14:42 ` [Tarantool-patches] [PATCH v2 5/7] build: change autoconf to cmake in curl build Alexander V. Tikhonov
2020-05-26 14:42 ` [Tarantool-patches] [PATCH v2 6/7] Skip failing test from out-of-source build Alexander V. Tikhonov
2020-05-26 14:42 ` [Tarantool-patches] [PATCH v2 7/7] gitlab-ci: add " Alexander V. Tikhonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200703111322.umrmzpgqqg54fo3i@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=o.piskunov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 1/7] build: static build needs more cleanup in sources' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox