From: Sergey Bronnikov <sergeyb@tarantool.org> To: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org, sergepetrenko@tarantool.org, gorcunov@gmail.com, lvasiliev@tarantool.org Subject: Re: [Tarantool-patches] [PATCH 2/4] replication: add advanced tests for sync replication Date: Fri, 3 Jul 2020 01:46:12 +0300 [thread overview] Message-ID: <20200702224612.GB5305@pony.bronevichok.ru> (raw) In-Reply-To: <012c8c196396cf963a0aa1f2d23814ff84b81cfb.1593723973.git.sergeyb@tarantool.org> Forgot to fix unreliable piece of code in a test that makes test flaky. Changes with fix are below, branch contains updated commit. diff --git a/test/replication/qsync_advanced.result b/test/replication/qsync_advanced.result index fa94c8339..53722c3f9 100644 --- a/test/replication/qsync_advanced.result +++ b/test/replication/qsync_advanced.result @@ -663,7 +663,7 @@ box.space.sync:drop() | --- | ... --- check behaviour with failed write to WAL on master (ERRINJ_WAL_IO) +-- Check behaviour with failed write to WAL on master (ERRINJ_WAL_IO). -- Testcase setup. test_run:switch('default') | --- @@ -849,15 +849,8 @@ test_run:switch('default') | - true | ... -- Enable synchronous mode. -s = box.space._space:get(box.space.sync.id) - | --- - | ... -new_s = s:update({{'=', 6, {is_sync=true}}}) - | --- - | ... -box.space._space:replace(new_s) +disable_sync_mode() | --- - | - [523, 1, 'sync', 'vinyl', 0, {'is_sync': true}, []] | ... -- Space is in sync mode now. box.cfg{replication_synchro_quorum=NUM_INSTANCES, replication_synchro_timeout=0.1} @@ -867,41 +860,28 @@ box.space.sync:insert{2} -- success | --- | - [2] | ... -box.space.sync:insert{3} -- success - | --- - | - [3] - | ... box.cfg{replication_synchro_quorum=BROKEN_QUORUM, replication_synchro_timeout=0.1} | --- | ... -box.space.sync:insert{4} -- failure - | --- - | - error: Quorum collection for a synchronous transaction is timed out - | ... -box.cfg{replication_synchro_quorum=NUM_INSTANCES, replication_synchro_timeout=0.1} - | --- - | ... -box.space.sync:insert{5} -- success +box.space.sync:insert{3} -- success | --- - | - [5] + | - [3] | ... -box.space.sync:select{} -- 1, 2, 3, 5 +box.space.sync:select{} -- 1, 2, 3 | --- | - - [1] | - [2] | - [3] - | - [5] | ... test_run:cmd('switch replica') | --- | - true | ... -box.space.sync:select{} -- 1, 2, 3, 5 +box.space.sync:select{} -- 1, 2, 3 | --- | - - [1] | - [2] | - [3] - | - [5] | ... -- Testcase cleanup. test_run:switch('default') diff --git a/test/replication/qsync_advanced.test.lua b/test/replication/qsync_advanced.test.lua index 270fd494d..9633ceb6c 100644 --- a/test/replication/qsync_advanced.test.lua +++ b/test/replication/qsync_advanced.test.lua @@ -307,20 +307,15 @@ test_run:cmd('switch replica') box.space.sync:select{} -- 1 test_run:switch('default') -- Enable synchronous mode. -s = box.space._space:get(box.space.sync.id) -new_s = s:update({{'=', 6, {is_sync=true}}}) -box.space._space:replace(new_s) +disable_sync_mode() -- Space is in sync mode now. box.cfg{replication_synchro_quorum=NUM_INSTANCES, replication_synchro_timeout=0.1} box.space.sync:insert{2} -- success -box.space.sync:insert{3} -- success box.cfg{replication_synchro_quorum=BROKEN_QUORUM, replication_synchro_timeout=0.1} -box.space.sync:insert{4} -- failure -box.cfg{replication_synchro_quorum=NUM_INSTANCES, replication_synchro_timeout=0.1} -box.space.sync:insert{5} -- success -box.space.sync:select{} -- 1, 2, 3, 5 +box.space.sync:insert{3} -- success +box.space.sync:select{} -- 1, 2, 3 test_run:cmd('switch replica') -box.space.sync:select{} -- 1, 2, 3, 5 +box.space.sync:select{} -- 1, 2, 3 -- Testcase cleanup. test_run:switch('default') box.space.sync:drop() On 00:13 Fri 03 Jul , sergeyb@tarantool.org wrote: > From: Sergey Bronnikov <sergeyb@tarantool.org> > > Part of #5055 > --- > test/replication/qsync_advanced.result | 939 +++++++++++++++++++++++ > test/replication/qsync_advanced.test.lua | 337 ++++++++ > 2 files changed, 1276 insertions(+) > create mode 100644 test/replication/qsync_advanced.result > create mode 100644 test/replication/qsync_advanced.test.lua
next prev parent reply other threads:[~2020-07-02 22:46 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <cover.1593723973.git.sergeyb@tarantool.org> 2020-06-29 23:15 ` [Tarantool-patches] [PATCH v2 00/19] Sync replication Vladislav Shpilevoy 2020-06-29 23:15 ` [Tarantool-patches] [PATCH v2 01/19] replication: introduce space.is_sync option Vladislav Shpilevoy 2020-06-30 23:00 ` Vladislav Shpilevoy 2020-07-01 15:55 ` Sergey Ostanevich 2020-07-01 23:46 ` Vladislav Shpilevoy 2020-07-02 8:25 ` Serge Petrenko 2020-06-29 23:15 ` [Tarantool-patches] [PATCH v2 10/19] txn_limbo: add ROLLBACK processing Vladislav Shpilevoy 2020-07-05 15:29 ` Vladislav Shpilevoy 2020-06-29 23:15 ` [Tarantool-patches] [PATCH v2 11/19] box: rework local_recovery to use async txn_commit Vladislav Shpilevoy 2020-06-29 23:15 ` [Tarantool-patches] [PATCH v2 12/19] replication: support ROLLBACK and CONFIRM during recovery Vladislav Shpilevoy 2020-06-29 23:15 ` [Tarantool-patches] [PATCH v2 13/19] replication: add test for synchro CONFIRM/ROLLBACK Vladislav Shpilevoy 2020-06-29 23:15 ` [Tarantool-patches] [PATCH v2 14/19] applier: remove writer_cond Vladislav Shpilevoy 2020-07-02 9:13 ` Serge Petrenko 2020-06-29 23:15 ` [Tarantool-patches] [PATCH v2 15/19] applier: send heartbeat not only on commit, but on any write Vladislav Shpilevoy 2020-07-01 23:55 ` Vladislav Shpilevoy 2020-07-03 12:23 ` Serge Petrenko 2020-06-29 23:15 ` [Tarantool-patches] [PATCH v2 16/19] txn_limbo: add diag_set in txn_limbo_wait_confirm Vladislav Shpilevoy 2020-06-29 23:15 ` [Tarantool-patches] [PATCH v2 17/19] replication: delay initial join until confirmation Vladislav Shpilevoy 2020-06-29 23:15 ` [Tarantool-patches] [PATCH v2 18/19] replication: only send confirmed data during final join Vladislav Shpilevoy 2020-06-29 23:15 ` [Tarantool-patches] [PATCH v2 19/19] replication: block async transactions when not empty limbo Vladislav Shpilevoy 2020-07-01 17:12 ` Sergey Ostanevich 2020-07-01 23:47 ` Vladislav Shpilevoy 2020-07-03 12:28 ` Serge Petrenko 2020-06-29 23:15 ` [Tarantool-patches] [PATCH v2 02/19] replication: introduce replication_synchro_* cfg options Vladislav Shpilevoy 2020-07-01 16:05 ` Sergey Ostanevich 2020-07-01 23:46 ` Vladislav Shpilevoy 2020-07-02 8:29 ` Serge Petrenko 2020-07-02 23:36 ` Vladislav Shpilevoy 2020-06-29 23:15 ` [Tarantool-patches] [PATCH v2 03/19] txn: add TXN_WAIT_ACK flag Vladislav Shpilevoy 2020-07-01 17:14 ` Sergey Ostanevich 2020-07-01 23:46 ` Vladislav Shpilevoy 2020-07-02 8:30 ` Serge Petrenko 2020-06-29 23:15 ` [Tarantool-patches] [PATCH v2 04/19] replication: make sync transactions wait quorum Vladislav Shpilevoy 2020-06-30 23:00 ` Vladislav Shpilevoy 2020-07-02 8:48 ` Serge Petrenko 2020-07-03 21:16 ` Vladislav Shpilevoy 2020-07-05 16:05 ` Vladislav Shpilevoy 2020-06-29 23:15 ` [Tarantool-patches] [PATCH v2 05/19] xrow: introduce CONFIRM and ROLLBACK entries Vladislav Shpilevoy 2020-06-29 23:15 ` [Tarantool-patches] [PATCH v2 06/19] txn: introduce various reasons for txn rollback Vladislav Shpilevoy 2020-06-29 23:15 ` [Tarantool-patches] [PATCH v2 07/19] replication: write and read CONFIRM entries Vladislav Shpilevoy 2020-06-29 23:15 ` [Tarantool-patches] [PATCH v2 08/19] replication: add support of qsync to the snapshot machinery Vladislav Shpilevoy 2020-07-02 8:52 ` Serge Petrenko 2020-07-08 11:43 ` Leonid Vasiliev 2020-06-29 23:15 ` [Tarantool-patches] [PATCH v2 09/19] txn_limbo: add timeout when waiting for acks Vladislav Shpilevoy 2020-06-29 23:22 ` [Tarantool-patches] [PATCH v2 00/19] Sync replication Vladislav Shpilevoy 2020-06-30 23:00 ` [Tarantool-patches] [PATCH v2 20/19] replication: add test for quorum 1 Vladislav Shpilevoy 2020-07-03 12:32 ` Serge Petrenko 2020-07-02 21:13 ` [Tarantool-patches] [PATCH 1/4] replication: regression test on gh-5119 [not fixed] sergeyb 2020-07-02 21:13 ` [Tarantool-patches] [PATCH 2/4] replication: add advanced tests for sync replication sergeyb 2020-07-02 22:46 ` Sergey Bronnikov [this message] 2020-07-02 23:20 ` Vladislav Shpilevoy 2020-07-06 12:30 ` Sergey Bronnikov 2020-07-06 23:31 ` Vladislav Shpilevoy 2020-07-07 12:12 ` Sergey Bronnikov 2020-07-07 20:57 ` Vladislav Shpilevoy 2020-07-08 12:07 ` Sergey Bronnikov 2020-07-08 22:13 ` Vladislav Shpilevoy 2020-07-09 9:39 ` Sergey Bronnikov 2020-07-02 21:13 ` [Tarantool-patches] [PATCH 3/4] replication: add tests for sync replication with anon replica sergeyb 2020-07-06 23:31 ` Vladislav Shpilevoy 2020-07-02 21:13 ` [Tarantool-patches] [PATCH 4/4] replication: add tests for sync replication with snapshots sergeyb 2020-07-02 22:46 ` Sergey Bronnikov 2020-07-02 23:20 ` Vladislav Shpilevoy 2020-07-06 23:31 ` Vladislav Shpilevoy 2020-07-07 16:00 ` Sergey Bronnikov 2020-07-06 23:31 ` [Tarantool-patches] [PATCH] Add new error injection constant ERRINJ_SYNC_TIMEOUT Vladislav Shpilevoy 2020-07-10 0:50 ` [Tarantool-patches] [PATCH v2 00/19] Sync replication Vladislav Shpilevoy 2020-07-10 7:40 ` Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200702224612.GB5305@pony.bronevichok.ru \ --to=sergeyb@tarantool.org \ --cc=gorcunov@gmail.com \ --cc=lvasiliev@tarantool.org \ --cc=sergepetrenko@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 2/4] replication: add advanced tests for sync replication' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox