From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v3 2/2] replication: append NOP as the last tx row
Date: Thu, 2 Jul 2020 18:37:43 +0300 [thread overview]
Message-ID: <20200702153743.GI2256@grain> (raw)
In-Reply-To: <106b9cbcf8577d6e3afbde57b15bc11d366c108e.1593696889.git.sergepetrenko@tarantool.org>
On Thu, Jul 02, 2020 at 04:39:51PM +0300, Serge Petrenko wrote:
> Since we stopped sending local space operations in replication, the last
> tx row has to be global in order to preserve tx boundaries on replica.
> If the last row happens to be a local one, replica will never receive
> the tx end marker, yielding the following errors:
> `ER_UNSUPPORTED: replication does not support interleaving
> transactions`.
>
> In order to fix the problem append a global NOP row at the tx end if
> it happens to end on a local row.
>
> Follow-up #4114
> Closes #4928
I've been trying to find out better place for this allocation (or even
use preallocated static one) but since we need to assign lsn later in
wal code none of ideas work. Thus lets keep it this way.
Reviewed-by: Cyrill Gorcunov <gorcunov@gmail.com>
next prev parent reply other threads:[~2020-07-02 15:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 13:39 [Tarantool-patches] [PATCH v3 0/2] fix replication tx boundaries after local space rework Serge Petrenko
2020-07-02 13:39 ` [Tarantool-patches] [PATCH v3 1/2] wal: fix tx boundaries Serge Petrenko
2020-07-02 13:39 ` [Tarantool-patches] [PATCH v3 2/2] replication: append NOP as the last tx row Serge Petrenko
2020-07-02 14:35 ` Cyrill Gorcunov
2020-07-02 14:49 ` Cyrill Gorcunov
2020-07-02 15:37 ` Cyrill Gorcunov [this message]
2020-07-02 20:30 ` Vladislav Shpilevoy
2020-07-03 11:24 ` Serge Petrenko
2020-07-03 21:29 ` Vladislav Shpilevoy
2020-07-04 17:25 ` Serge Petrenko
2020-07-06 6:48 ` Vladislav Shpilevoy
2020-07-06 7:47 ` [Tarantool-patches] [PATCH v3 0/2] fix replication tx boundaries after local space rework Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200702153743.GI2256@grain \
--to=gorcunov@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v3 2/2] replication: append NOP as the last tx row' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox