Tarantool development patches archive
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: tml <tarantool-patches@dev.tarantool.org>
Cc: yaroslav.dynnikov@gmail.com
Subject: [Tarantool-patches] [PATCH v3 0/3] log: allow json formatter in boottime logger
Date: Thu,  2 Jul 2020 12:50:51 +0300	[thread overview]
Message-ID: <20200702095054.367131-1-gorcunov@gmail.com> (raw)

For some reason we've disabled usage of json formatter in early
logging since the commit 098324556. Lets allow it back.

v2:
 - add early verification of options for cases like
   box.cfg{log="syslog:", log_format="json"}
 - extend test

v3:
 - pass the whole cfg table into verify_option helper
 - use string.startswith helper in verify_format

branch gorcunov/gh-5121-logger-boot-json-3
issue https://github.com/tarantool/tarantool/issues/5121

Cyrill Gorcunov (3):
  core/say: allow to use json in boot logger
  lua/log: allow to use json formatter early
  test: app-tap/logger -- test json in boottime logger

 src/box/lua/load_cfg.lua     |  6 +++---
 src/lib/core/say.c           |  7 ++----
 src/lua/log.lua              | 42 +++++++++++++++++++++++++++---------
 test/app-tap/logger.test.lua | 19 ++++++++++++----
 4 files changed, 52 insertions(+), 22 deletions(-)

-- 
2.26.2

             reply	other threads:[~2020-07-02  9:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-02  9:50 Cyrill Gorcunov [this message]
2020-07-02  9:50 ` [Tarantool-patches] [PATCH v3 1/3] core/say: allow to use json in boot logger Cyrill Gorcunov
2020-07-02  9:50 ` [Tarantool-patches] [PATCH v3 2/3] lua/log: allow to use json formatter early Cyrill Gorcunov
2020-07-02 10:05   ` Oleg Babin
2020-07-02 10:18     ` Cyrill Gorcunov
2020-07-02 10:29       ` Oleg Babin
2020-07-02  9:50 ` [Tarantool-patches] [PATCH v3 3/3] test: app-tap/logger -- test json in boottime logger Cyrill Gorcunov
2020-07-02 10:08 ` [Tarantool-patches] [PATCH v3 0/3] log: allow json formatter " Oleg Babin
2020-07-02 10:46 ` Yaroslav Dynnikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200702095054.367131-1-gorcunov@gmail.com \
    --to=gorcunov@gmail.com \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=yaroslav.dynnikov@gmail.com \
    --subject='Re: [Tarantool-patches] [PATCH v3 0/3] log: allow json formatter in boottime logger' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox