Re: [Tarantool-patches] [PATCH 1/1] box: fixed box.info:memory()

[Igor Munkin <imun@tarantool.org>]

Olya,

Thanks for the patch! I see the patch subject differs from the
corresponding commit subject you've pushed to the upstream. What is the
final one? Please also consider several nits I left below.

On 29.06.20, Olga Arkhangelskaia wrote:
> Fix box.info:memory() output. Now it has the same output as box.info.memory().
> ---
> Closes 4668
>  src/box/lua/info.c                            |  1 +
>  test/box-tap/gh-4668-box-info-memory.test.lua | 15 +++++++++++++++

Typo: s/gh-4668/gh-4688/.

>  2 files changed, 16 insertions(+)
>  create mode 100755 test/box-tap/gh-4668-box-info-memory.test.lua
> 

<snipped>

> diff --git a/test/box-tap/gh-4668-box-info-memory.test.lua b/test/box-tap/gh-4668-box-info-memory.test.lua
> new file mode 100755
> index 000000000..1a13fa903
> --- /dev/null
> +++ b/test/box-tap/gh-4668-box-info-memory.test.lua
> @@ -0,0 +1,15 @@
> +#!/usr/bin/env tarantool
> +--
> +-- gh-4668: box.info:memory() displayed full content of box.info

Ditto.

> +--
> +local tap = require('tap')
> +local test = tap.test("Tarantool 4668")

Ditto.

> +test:plan(1)
> +
> +box.cfg()
> +
> +a = box.info.memory()
> +b = box.info:memory()
> +
> +test:is(table.concat(a), table.concat(b), "box.info:memory")
> +os.exit(0)
> -- 
> 2.20.1 (Apple Git-117)
> 

-- 
Best regards,
IM