Tarantool development patches archive
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Oleg Babin <olegrok@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>, yaroslav.dynnikov@gmail.com
Subject: Re: [Tarantool-patches] [PATCH 0/3] log: allow json formatter in boottime logger
Date: Mon, 29 Jun 2020 16:37:39 +0300	[thread overview]
Message-ID: <20200629133739.GC2256@grain> (raw)
In-Reply-To: <34d2d32a-eb7e-a6a4-d2c8-57448563f02b@tarantool.org>

On Mon, Jun 29, 2020 at 03:50:00PM +0300, Oleg Babin wrote:
> Hi! Thanks for your patch. Looks good but I want to clarify one thing:
> 
> 
> ```
> 
> tarantool> log.cfg{log = 'syslog', format='json'}
> ---
> ...
> 
> ```
> 
> It works fine but seems such command should throw an error:
> 
> "json can't be used with syslog logger", isn't it?
> 
> It happened because "ffi.C.log_type()" returns "0" -- boot-time logger.

Good catch! Due to code structure this case is not covered.
I'll update the series and the test. Thanks a lot!!!

  reply	other threads:[~2020-06-29 13:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-29 11:23 Cyrill Gorcunov
2020-06-29 11:23 ` [Tarantool-patches] [PATCH 1/3] core/say: allow to use json in boot logger Cyrill Gorcunov
2020-06-29 11:23 ` [Tarantool-patches] [PATCH 2/3] lua/log: allow to use json formatter early Cyrill Gorcunov
2020-06-29 11:23 ` [Tarantool-patches] [PATCH 3/3] test: app-tap/logger -- test json in boottime logger Cyrill Gorcunov
2020-06-29 12:50 ` [Tarantool-patches] [PATCH 0/3] log: allow json formatter " Oleg Babin
2020-06-29 13:37   ` Cyrill Gorcunov [this message]
2020-07-02 11:26 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200629133739.GC2256@grain \
    --to=gorcunov@gmail.com \
    --cc=olegrok@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=yaroslav.dynnikov@gmail.com \
    --subject='Re: [Tarantool-patches] [PATCH 0/3] log: allow json formatter in boottime logger' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox