From: Alexander Turenko <alexander.turenko@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: Oleg Piskunov <o.piskunov@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 1/7] build: static build needs more cleanup in sources
Date: Fri, 26 Jun 2020 16:51:06 +0300 [thread overview]
Message-ID: <20200626135106.4o7mraweajyd4izo@tkn_work_nb> (raw)
In-Reply-To: <b07b25b57cb46c9d1c618ee3c1bf9189b77c1525.1590503508.git.avtikhon@tarantool.org>
> diff --git a/Dockerfile.staticbuild b/Dockerfile.staticbuild
> index 253f2d5e9..f67f46f5e 100644
> --- a/Dockerfile.staticbuild
> +++ b/Dockerfile.staticbuild
> @@ -75,7 +75,7 @@ RUN set -x && \
> RUN set -x && \
> find . -name 'CMakeFiles' -type d -exec rm -rf {} + && \
> find . -name 'CMakeCache.txt' -type f -delete && \
> - rm -rf build
> + rm -rf build test/small test/luajit-tap
What if I'll push a short-term branch that adds one more test directory?
I think that the directory should be cleaned up entirely (git clean for
sources and submodules). And it seems that it is done with [1], right?
Such spotted cleanup will insuperably fails in some cases.
Anyway, I don't have objections against this certain patch if it still
needed after [1], just noted that it necessary only because the overall
approach is not good.
[1]: https://github.com/tarantool/tarantool/issues/5036
WBR, Alexander Turenko.
next prev parent reply other threads:[~2020-06-26 13:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 14:42 [Tarantool-patches] [PATCH v2 0/7] Implement OOS build Alexander V. Tikhonov
2020-05-26 14:42 ` [Tarantool-patches] [PATCH v2 1/7] build: static build needs more cleanup in sources Alexander V. Tikhonov
2020-06-26 13:51 ` Alexander Turenko [this message]
2020-07-03 11:13 ` Kirill Yukhin
2020-05-26 14:42 ` [Tarantool-patches] [PATCH v2 2/7] build: fix static build w/ dockerfile with cmake Alexander V. Tikhonov
2020-05-26 14:42 ` [Tarantool-patches] [PATCH v2 3/7] build: enable cmake in curl build Alexander V. Tikhonov
2020-05-26 14:42 ` [Tarantool-patches] [PATCH v2 4/7] Fix curl repository for out-of-source build Alexander V. Tikhonov
2020-05-26 14:42 ` [Tarantool-patches] [PATCH v2 5/7] build: change autoconf to cmake in curl build Alexander V. Tikhonov
2020-05-26 14:42 ` [Tarantool-patches] [PATCH v2 6/7] Skip failing test from out-of-source build Alexander V. Tikhonov
2020-05-26 14:42 ` [Tarantool-patches] [PATCH v2 7/7] gitlab-ci: add " Alexander V. Tikhonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200626135106.4o7mraweajyd4izo@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=o.piskunov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 1/7] build: static build needs more cleanup in sources' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox