Re: [Tarantool-patches] [PATCH v1] test: fix flaky replication/wal_off.test.lua

[Kirill Yukhin <kyukhin@tarantool.org>]

Hello,

On 19 июн 14:48, Alexander V. Tikhonov wrote:
> Found issue:
> 
> [003] --- replication/wal_off.result	Thu Apr 25 13:10:18 2019
> [003] +++ replication/wal_off.reject	Tue Jul 16 17:10:31 2019
> [003] @@ -95,6 +95,8 @@
> [003]  ...
> [003]  while string.find(box.info.replication[wal_off_id].upstream.message, check) == nil do fiber.sleep(0.01) end
> [003]  ---
> [003] +- error: '[string "while string.find(box.info.replication[wal_of..."]:1: bad argument
> [003] +    #1 to ''find'' (string expected, got nil)'
> [003]  ...
> [003]  box.cfg { replication = "" }
> [003]  ---
> 
> To check the upstream status and it's message need to wait until an
> upstream appears. This prevents an attempt to index a nil value when
> one of those functions are called before a record about a peer appears
> in box.info.replication. It was observed on test:
>   replication/show_error_on_disconnect
> after commit
>   c6bea65f8ef5f6c737cf70c0127189d0ebcbc36e ('replication: recfg with 0
> quorum returns immediately').
> 
> Closes #4355
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4355-replication-wall-off
> Issue: https://github.com/tarantool/tarantool/issues/4355

I've checked your patch into 1.10, 2.3, 2.4 and master.

--
Regards, Kirill Yukhin