From: Alexander Turenko <alexander.turenko@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 0/4] Fix app/digest and app/socket on 1.10
Date: Tue, 23 Jun 2020 17:08:22 +0300 [thread overview]
Message-ID: <20200623140822.ki2u4siym7eh63yw@tkn_work_nb> (raw)
In-Reply-To: <20200622135838.GA1740@hpalx>
> commit 6595e9fccfb3f52e9c551458cbe0285d651c812b
> Author: Alexander V. Tikhonov <avtikhon@tarantool.org>
> Date: Thu Jun 18 01:55:58 2020 +0300
>
> Bump libyaml
>
> Set to use in libyaml tarantool-1.10 branch with the following
> bumped commit:
>
> f1d1e5e0a5f6e6adeebe0e2c5e95a6ee729426e4 'cmake: make sure yaml is built statically when used in tarantool'
Nit: I would carry the line in the commit message.
Nit: I would use cherry-pick -x for picking commits from libyaml master
for tarantool-1.10 branch.
I guess a commit that fixes C89 build needed here too (ask Sergey P.
where he meet a problem with it).
Maybe it is better to place the libyaml update first, before enabling
bundling by default: this way looks more safe.
Other than that I have no objection.
LGTM. No need to re-review with me after the changes suggested above:
just carefully test it.
WBR, Alexander Turenko.
next prev parent reply other threads:[~2020-06-23 14:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 5:36 Alexander V. Tikhonov
2020-06-18 5:36 ` [Tarantool-patches] [PATCH v1 1/4] build: enable bundled libyaml for all systems Alexander V. Tikhonov
2020-06-18 5:36 ` [Tarantool-patches] [PATCH v1 2/4] build: remove libyaml from rpm/deb dependencies Alexander V. Tikhonov
2020-06-18 5:36 ` [Tarantool-patches] [PATCH v1 3/4] Bump libyaml Alexander V. Tikhonov
2020-06-18 5:36 ` [Tarantool-patches] [PATCH v1 4/4] Extend range of printable unicode characters Alexander V. Tikhonov
2020-06-18 10:39 ` [Tarantool-patches] [PATCH v1 0/4] Fix app/digest and app/socket on 1.10 Alexander Turenko
2020-06-22 13:58 ` Alexander V. Tikhonov
2020-06-23 14:08 ` Alexander Turenko [this message]
2020-06-26 9:46 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200623140822.ki2u4siym7eh63yw@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1 0/4] Fix app/digest and app/socket on 1.10' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox