From: Nikita Pettik <korablev@tarantool.org> To: imeevma@tarantool.org Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH v2 2/7] sql: remove mem_apply_type() from OP_MakeRecord Date: Mon, 22 Jun 2020 08:48:38 +0000 [thread overview] Message-ID: <20200622084838.GB30686@tarantool.org> (raw) In-Reply-To: <acf68a1445652420838bab1af03fbdb3a5121045.1592397263.git.imeevma@gmail.com> On 17 Jun 15:36, imeevma@tarantool.org wrote: > This patch removes type changing from OP_MakeRecord. Please reflect user-visible changes in commit message. > Part of #4230 > --- > src/box/sql/analyze.c | 7 +------ > src/box/sql/delete.c | 8 ++------ > src/box/sql/expr.c | 8 +------- > src/box/sql/fk_constraint.c | 9 ++------- > src/box/sql/select.c | 25 ++++++------------------- > src/box/sql/update.c | 14 +++----------- > src/box/sql/vdbe.c | 19 +------------------ > test/sql-tap/in3.test.lua | 4 ++-- > 8 files changed, 18 insertions(+), 76 deletions(-) > > diff --git a/test/sql-tap/in3.test.lua b/test/sql-tap/in3.test.lua > index e29db9d93..f7681640e 100755 > --- a/test/sql-tap/in3.test.lua > +++ b/test/sql-tap/in3.test.lua > @@ -354,7 +354,7 @@ test:do_test( > return exec_neph(" SELECT y IN (SELECT a FROM t1) FROM t2 ") > end, { > -- <in3-3.5> > - 1, true > + 1, false > -- </in3-3.5> > }) > > @@ -378,7 +378,7 @@ test:do_test( > return exec_neph(" SELECT y IN (SELECT c FROM t1) FROM t2 ") > end, { > -- <in3-3.7> > - 1, true > + 1, false > -- </in3-3.7> > }) > > -- > 2.25.1 >
next prev parent reply other threads:[~2020-06-22 8:48 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-17 12:36 [Tarantool-patches] [PATCH v2 0/7] Remove implicit cast imeevma 2020-06-17 12:36 ` [Tarantool-patches] [PATCH v2 1/7] sql: remove implicit cast for assignment imeevma 2020-06-22 8:23 ` Nikita Pettik 2020-06-22 20:47 ` Vladislav Shpilevoy 2020-06-22 21:08 ` Nikita Pettik 2020-06-23 6:44 ` Mergen Imeev 2020-06-17 12:36 ` [Tarantool-patches] [PATCH v2 2/7] sql: remove mem_apply_type() from OP_MakeRecord imeevma 2020-06-22 8:48 ` Nikita Pettik [this message] 2020-06-17 12:36 ` [Tarantool-patches] [PATCH v2 3/7] sql: replace ApplyType by CheckType for IN operator imeevma 2020-06-22 9:32 ` Nikita Pettik 2020-06-17 12:36 ` [Tarantool-patches] [PATCH v2 4/7] sql: remove mem_apply_type() from OP_MustBeInt imeevma 2020-06-22 10:07 ` Nikita Pettik 2020-06-17 12:36 ` [Tarantool-patches] [PATCH v2 5/7] sql: remove implicit cast from string for comparison imeevma 2020-06-22 12:25 ` Nikita Pettik 2020-06-17 12:36 ` [Tarantool-patches] [PATCH v2 6/7] sql: remove OP_ApplyType imeevma 2020-06-17 12:36 ` [Tarantool-patches] [PATCH v2 7/7] sql: use type instead of value in type mismatch error imeevma -- strict thread matches above, loose matches on Subject: below -- 2020-06-11 12:54 [Tarantool-patches] [PATCH v2 0/7] Remove implicit cast imeevma 2020-06-11 12:54 ` [Tarantool-patches] [PATCH v2 2/7] sql: remove mem_apply_type() from OP_MakeRecord imeevma
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200622084838.GB30686@tarantool.org \ --to=korablev@tarantool.org \ --cc=imeevma@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v2 2/7] sql: remove mem_apply_type() from OP_MakeRecord' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox