* [Tarantool-patches] [PATCH] journal: fix typo in journal_no_write_async()
@ 2020-06-19 18:09 Serge Petrenko
2020-06-19 18:19 ` Cyrill Gorcunov
0 siblings, 1 reply; 2+ messages in thread
From: Serge Petrenko @ 2020-06-19 18:09 UTC (permalink / raw)
To: tarantool-patches
Branch: gh-4842-sync-replication
---
src/box/journal.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/box/journal.c b/src/box/journal.c
index c576dfcf6..d84f960d5 100644
--- a/src/box/journal.c
+++ b/src/box/journal.c
@@ -37,7 +37,7 @@ journal_no_write_async(struct journal *journal,
struct journal_entry *entry)
{
(void)journal;
- assert(true);
+ assert(false);
errno = EINVAL;
diag_set(SystemError, "write_async wrong context");
@@ -49,7 +49,7 @@ journal_no_write_async(struct journal *journal,
void
journal_no_write_async_cb(struct journal_entry *entry)
{
- assert(true);
+ assert(false);
errno = EINVAL;
diag_set(SystemError, "write_async_cb wrong context");
--
2.24.3 (Apple Git-128)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Tarantool-patches] [PATCH] journal: fix typo in journal_no_write_async()
2020-06-19 18:09 [Tarantool-patches] [PATCH] journal: fix typo in journal_no_write_async() Serge Petrenko
@ 2020-06-19 18:19 ` Cyrill Gorcunov
0 siblings, 0 replies; 2+ messages in thread
From: Cyrill Gorcunov @ 2020-06-19 18:19 UTC (permalink / raw)
To: Serge Petrenko; +Cc: tarantool-patches
On Fri, Jun 19, 2020 at 09:09:14PM +0300, Serge Petrenko wrote:
> Branch: gh-4842-sync-replication
> ---
> src/box/journal.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Cyrill Gorcunov <gorcunov@gmail.com>
Good catch! Kirill, can we please merge this partiular patch
into the master branch?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-19 18:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-19 18:09 [Tarantool-patches] [PATCH] journal: fix typo in journal_no_write_async() Serge Petrenko
2020-06-19 18:19 ` Cyrill Gorcunov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox