Tarantool development patches archive
 help / color / mirror / Atom feed
From: Nikita Pettik <korablev@tarantool.org>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] sql: raise an error on attempt to use HASH index in SQL
Date: Thu, 18 Jun 2020 18:49:03 +0000	[thread overview]
Message-ID: <20200618184903.GA17291@tarantool.org> (raw)
In-Reply-To: <20200617144536.yit7qljhf26efm5e@tarantool.org>

On 17 Jun 17:45, Kirill Yukhin wrote:
> Hello,
> 
> Thanks a lot for review.
> 
> My answers inlined. Iterative patch in the bottom.
> Branch force-pushed.
>

LGTM

The only thing missing is a docbot request (in case it is still
undocumented).

  reply	other threads:[~2020-06-18 18:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-16 15:06 Kirill Yukhin
2020-06-16 23:08 ` Nikita Pettik
2020-06-17 14:45   ` Kirill Yukhin
2020-06-18 18:49     ` Nikita Pettik [this message]
2020-06-19  8:36 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200618184903.GA17291@tarantool.org \
    --to=korablev@tarantool.org \
    --cc=kyukhin@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] sql: raise an error on attempt to use HASH index in SQL' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox