From: Alexander Turenko <alexander.turenko@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1] test: fix flaky box/net.box_readahead_gh-3958 test
Date: Thu, 18 Jun 2020 21:39:29 +0300 [thread overview]
Message-ID: <20200618183929.heifae4w6jbpqxqt@tkn_work_nb> (raw)
In-Reply-To: <8ce5e510f40a14583da6fc83c6f8f127d134a3c5.1592395183.git.avtikhon@tarantool.org>
Filed https://github.com/tarantool/test-run/issues/214 , where I
proposed to add a mechanism to elide all past logs for grep_log() and
wait_log().
Let's consider vinyl/compact.test.lua way for a while:
| -- <prepare>
| require('log').info(string.rep(" ", 1024))
| -- <commands that either produce some logs or don't>
| test_run:wait_log(<...>, <...>, 400) == nil
(Don't miss [1]. Don't sure whether it is still actual after [2].
Please, either check it strongly or keep being on the safe side with
1000/400 magic numbers.)
This way is less intruisive than modifying another test.
CCed Sergey as author of the test case.
[1]: https://github.com/tarantool/tarantool/commit/43965c89fe560fdaa7d916a447a74b9bb3453171
[2]: https://github.com/tarantool/tarantool/commit/437e82ed6bbed98e1fa54cbf8bec178fab50a80d
prev parent reply other threads:[~2020-06-18 18:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 12:00 Alexander V. Tikhonov
2020-06-18 18:39 ` Alexander Turenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200618183929.heifae4w6jbpqxqt@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1] test: fix flaky box/net.box_readahead_gh-3958 test' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox