From: Kirill Yukhin <kyukhin@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 0/2] ASAN build
Date: Tue, 16 Jun 2020 11:56:35 +0300 [thread overview]
Message-ID: <20200616085635.xwkmwruah72f4khw@tarantool.org> (raw)
In-Reply-To: <cover.1592151487.git.v.shpilevoy@tarantool.org>
Hello,
On 14 июн 18:24, Vladislav Shpilevoy wrote:
> The build was broken because sql static library couldn't find some
> box symbols, when UB sanitizer was enabled.
>
> Appeared, that the whole sql library was broken, because there was
> a cyclic dependency between box and sql libraries.
>
> The patch merged sql and box libraries.
>
> After their merge appeared that some UB sanitations 'woken up' and
> started failing, about nullability attributes and usage of NULL
> pointers. All of them were false-positive so the second patch
> disabled them.
>
> After this patchset the build works, but the tests don't pass
> because of this:
> https://github.com/tarantool/tarantool/issues/5078.
>
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-5067-asan-build
> Issue: https://github.com/tarantool/tarantool/issues/5067
> Issue: https://github.com/tarantool/tarantool/issues/4609
I've checked your patch set into master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2020-06-16 8:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-14 16:24 Vladislav Shpilevoy
2020-06-14 16:24 ` [Tarantool-patches] [PATCH 1/2] sql: don't build sql as a separate library Vladislav Shpilevoy
2020-06-15 15:42 ` Timur Safin
2020-06-14 16:24 ` [Tarantool-patches] [PATCH 2/2] cmake: split UB sanitations into separate flags Vladislav Shpilevoy
2020-06-15 15:41 ` Timur Safin
2020-06-15 22:19 ` Vladislav Shpilevoy
2020-06-15 14:01 ` [Tarantool-patches] [PATCH 0/2] ASAN build Alexander Turenko
2020-06-15 22:21 ` Vladislav Shpilevoy
2020-06-15 23:04 ` Alexander Turenko
2020-06-15 23:15 ` Vladislav Shpilevoy
2020-06-15 15:43 ` Timur Safin
2020-06-16 8:56 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616085635.xwkmwruah72f4khw@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/2] ASAN build' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox