Re: [Tarantool-patches] [PATCH 0/2] ASAN build

[Alexander Turenko <alexander.turenko@tarantool.org>]

On Tue, Jun 16, 2020 at 12:21:13AM +0200, Vladislav Shpilevoy wrote:
> Hi!
> 
> On 15/06/2020 16:01, Alexander Turenko wrote:
> > LGTM except broken coverage reporting:
> > 
> > https://travis-ci.org/github/tarantool/tarantool/jobs/698246927
> > 
> > It looks quite similar to
> > https://github.com/tarantool/tarantool/commit/415c05868f95b45a56904d5aa581358aced05efe
> > 
> > Maybe we should add '-o ${CMAKE_BINARY_DIR}/src/box/sql/parse.c' to
> > lemon call to write absolute path in #line directives, which may help to
> > avoid ambiguity.
> 
> Thanks for noticing and for the proposed fix. I did this:
> 
> -    COMMAND ${EXT_BIN_DIR}/lemon -T${EXT_SRC_DIR}/lempar.c ${SQL_SRC_DIR}/parse.y
> +    COMMAND ${EXT_BIN_DIR}/lemon -T${EXT_SRC_DIR}/lempar.c -o${SQL_BIN_DIR}/parse ${SQL_SRC_DIR}/parse.y

Nit: I would use `-o${SQL_BIN_DIR}/parse.c` with explicit `.c` suffix.
The effect is the same, but the command line looks more natural. Up to
you.

> 
> Now parse.c contains absolute paths in #line directives. But I couldn't
> wait if it helped - travis is awfully slow. Lets see if it helped tomorrow,
> when the job will be finally done.

You may verify it locally:

$ cmake .                        \
    -DCMAKE_BUILD_TYPE=Debug     \
    -DENABLE_BACKTRACE=ON        \
    -DENABLE_DIST=ON             \
    -DENABLE_BUNDLED_LIBCURL=OFF \
    -DENABLE_GCOV=ON
$ make -j
$ echo 'print(42)' | ./src/tarantool
$ lcov -c -d src -o /dev/null 2>&1 | grep WARNING

Note: It seems the output format may vary across lcov versions, I see no
WARNING mark on Travis-CI, just the following lines:

 | Processing box/CMakeFiles/box.dir/sql/parse.c.gcda
 | Cannot open source file parse.c

After your fix the warning disappears.

BTW, I see warnings re uri.rl / uri.c locally again:

 | geninfo: WARNING: could not open /home/alex/p/tarantool-meta/r/t-3/src/lib/uri/src/lib/uri/uri.rl
 | geninfo: WARNING: could not open /home/alex/p/tarantool-meta/r/t-3/src/lib/uri/src/lib/uri/uri.c
 | geninfo: WARNING: some exclusion markers may be ignored

But don't see them on Travis-CI. This is strange. But it doesn't look
related to your patchset: I see the same on master
(2.5.0-142-ged935572b).