From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Olga Arkhangelskaia <arkholga@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] cmake: set CMP0037 policy to NEW by default
Date: Mon, 15 Jun 2020 01:22:54 +0300 [thread overview]
Message-ID: <20200614222254.blduhmzlgv2cfbba@tkn_work_nb> (raw)
In-Reply-To: <a4e60859-7776-9989-79bf-6996e3d1452f@tarantool.org>
LGTM.
Pushed to master and 2.4. Several minor comments below.
WBR, Alexander Turenko.
On Wed, May 27, 2020 at 01:15:35PM +0300, Olga Arkhangelskaia wrote:
> Hi Igor!
>
> Thanks for the review:
>
> I have changed the order and left a small comment, so the diff looks like:
>
> -if(CMAKE_VERSION VERSION_LESS 3.11)
> - if(POLICY CMP0037)
> +if (POLICY CMP0037)
> + # https://cmake.org/cmake/help/v3.11/release/3.11.html#other-changes
> + # cmake below 3.11 reserves name test. Use old politics.
Nit: AFAIU, 'politics' and 'policy' are not synonyms: the former is more
about goverment actions (see [1]).
> + if (CMAKE_VERSION VERSION_LESS 3.11)
> cmake_policy(SET CMP0037 OLD)
> - endif(POLICY CMP0037)
> -else()
> - if(POLICY CMP0037)
> + else()
> + # Starting from cmake 3.11 name test reserved in special cases and
> can
> + # be used as target name.
Nit: We usually fit our comments within 66 symbols (except URIs).
> cmake_policy(SET CMP0037 NEW)
> - endif(POLICY CMP0037)
> + endif()
> endif()
I don't see those changes on the branch [2]. Anyway, I applied those
changes manually and changes according to the comments above, pushed it
to master and 2.4 and removed the branch.
[1]: https://dictionary.cambridge.org/us/grammar/british-grammar/politics-political-politician-or-policy
[2]: OKriw/gh-3587-CMP0037-OLD-cmake-deprecation-warning-full-ci
prev parent reply other threads:[~2020-06-14 22:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 12:15 Olga Arkhangelskaia
2020-04-27 17:09 ` Igor Munkin
2020-05-21 15:33 ` Olga Arkhangelskaia
2020-05-25 12:28 ` Igor Munkin
2020-05-25 16:19 ` Olga Arkhangelskaia
2020-05-26 8:59 ` Igor Munkin
2020-05-26 9:12 ` Igor Munkin
2020-05-27 10:17 ` Olga Arkhangelskaia
2020-05-27 10:15 ` Olga Arkhangelskaia
2020-06-14 22:22 ` Alexander Turenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200614222254.blduhmzlgv2cfbba@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=arkholga@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] cmake: set CMP0037 policy to NEW by default' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox