From: Alexander Turenko <alexander.turenko@tarantool.org>
To: HustonMmmavr <huston.mavr@gmail.com>
Cc: tarantool-patches@dev.tarantool.org,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
yaroslav.dynnikov@gmail.com
Subject: Re: [Tarantool-patches] [PATCH] cmake: cleanup src/CMakeLists.txt
Date: Mon, 15 Jun 2020 00:34:51 +0300 [thread overview]
Message-ID: <20200614213451.bf3dadnmqxsozfn6@tkn_work_nb> (raw)
In-Reply-To: <20200611002510.35349-1-huston.mavr@gmail.com>
LGTM.
Vlad, can you look at the patch?
WBR, Alexander Turenko.
On Thu, Jun 11, 2020 at 03:25:10AM +0300, HustonMmmavr wrote:
> Removed definition and initialization of EXPORT_LIST variable at file
> src/CMakeLists.txt. After patch 03790ac551 this variable is unused
> (no reference to this variable after its initialization can be found
> in whole project) and it is only misleading.
>
> Closes #5066
I would also mark it as follow up for #2971.
> ---
> I've builded tarantool before applying this changes and after.
> Then I've checked difference in tarantool binary file symbols with
> nm and diff commands and there was no difference.
>
> Issue: https://github.com/tarantool/tarantool/issues/5066
> Branch: https://github.com/tarantool/tarantool/tree/HustonMmmavr/gh-5066-delete-unusued-export-list
>
> @ChangeLog
> - Cleanup src/CMakeLists.txt (gh-5066)
This change is not visible for a user, so I would not add a changelog
entry for it.
next prev parent reply other threads:[~2020-06-14 21:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 0:25 HustonMmmavr
2020-06-14 21:34 ` Alexander Turenko [this message]
2020-06-15 17:27 ` Mavr Huston
2020-06-15 21:20 ` Vladislav Shpilevoy
2020-06-17 15:29 ` Mavr Huston
2020-06-17 23:09 ` Vladislav Shpilevoy
2020-06-19 13:02 ` Yaroslav Dynnikov
2020-06-19 23:39 ` Vladislav Shpilevoy
2020-06-23 20:31 ` Yaroslav Dynnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200614213451.bf3dadnmqxsozfn6@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=huston.mavr@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--cc=yaroslav.dynnikov@gmail.com \
--subject='Re: [Tarantool-patches] [PATCH] cmake: cleanup src/CMakeLists.txt' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox