Re: [Tarantool-patches] [PATCH] fio/coio: handle partial writes

[Cyrill Gorcunov <gorcunov@gmail.com>]

On Thu, Jun 11, 2020 at 09:56:31PM +0200, Vladislav Shpilevoy wrote:
> > If you mean to merge into master branch -- I don't have such rights ;)
> 
> Aha, so you changed the branch, but didn't say it anywhere. I was
> looking at the branch you specified in the cover letter. Just a note -
> better do a force push on the same branch. Having all these v1, v2, v15,
> does not simplify the review. Even when you mention branch change in
> one of the emails, still during the active review process with lots of
> emails this one could be lost, and people would review the old branch
> accidentally.

Sorry for confusing you. I did it on a purpose -- I never do a force push
until everything is settle down, mostly for history reason and to keep
old changes and being able to make a diff between branches. Also I
sent a new version as a separate email.

Still I'll mark for myself that you prefer a force push instead and
will try to follow this rule next time. Thanks for review! And sorry
again for confusion.