Re: [Tarantool-patches] [PATCH 1/2] test: add libisatty to test local console

[Igor Munkin <imun@tarantool.org>]

Olya,

Thanks for the patch! I see no reason to introduce this auxiliary
library as a separate patch. Please consider some nits below.

On 10.06.20, Olga Arkhangelskaia wrote:
> From: Olga <arkholga@tarantool.org>
> 
> Local console is impossible to test within pipe, tatantool -i.

Typo: s/within/with/.
Typo: s/tatantool/tarantool/.

Minor: it's worth to describe the exact behaviour preventing tarantool
start with interactive console (i.e. isatty check) and mention the
issue[1] confirming that such behaviour is not OK.

> isatty lib was added to overcome isatty check and test local console.

Typo: s/overcome/overload/.

> Hack by Alexandr Turenko.

Minor: I failed to find such practice in our repo. If you want to
mention Sasha as author of this way to test local console, I guess you
can just add a Co-authored-by tag (if Sasha doesn't mind).

I also think, it's worth to mention the issue that motivates this patch.
Something like "Needed for #4317" is enough.

> ---
>  test/CMakeLists.txt | 8 ++++++++
>  test/isatty.c       | 5 +++++

Minor: it's better to place this library to test/app-tap directory. In
this case it simply doesn't spoil the root one.

>  2 files changed, 13 insertions(+)
>  create mode 100644 test/isatty.c
> 

<snipped>

> -- 
> 2.20.1 (Apple Git-117)
> 

[1]: https://github.com/tarantool/tarantool/issues/5064

-- 
Best regards,
IM