From: Roman Khabibov <roman.habibov@tarantool.org> To: tarantool-patches@dev.tarantool.org Cc: v.shpilevoy@tarantool.org Subject: [Tarantool-patches] [PATCH v3 0/2] Use-unify-pattern-for-column-names Date: Thu, 11 Jun 2020 18:18:51 +0300 [thread overview] Message-ID: <20200611151853.24398-1-roman.habibov@tarantool.org> (raw) I decided to drop a patch to remove the append to the names "_N". The problem was much deeper than I thought. I have not yet been able to write a sane patch for distinguishing columns with the same name from different tables in a certain kind of queries. I'll do it in a separate branch later. Branch: https://github.com/tarantool/tarantool/tree/romanhabibov/gh-3962-column Issue: https://github.com/tarantool/tarantool/issues/3962 @ChangeLog - Name all automatically generated column with the pattern "COLUMN_N". - Fix a little bug with span display. Roman Khabibov (2): sql: use unify pattern for column names sql: print span more properly src/box/sql/select.c | 52 +-- src/box/sql/sqlInt.h | 15 + test/box/function1.result | 12 +- test/sql-tap/colname.test.lua | 106 +++++- test/sql-tap/select1.test.lua | 21 +- test/sql-tap/select6.test.lua | 22 +- test/sql-tap/view.test.lua | 4 +- test/sql/bind.result | 42 +-- test/sql/boolean.result | 354 +++++++++---------- test/sql/collation.result | 14 +- test/sql/errinj.result | 2 +- test/sql/foreign-keys.result | 4 +- test/sql/full_metadata.result | 18 +- test/sql/func-recreate.result | 2 +- test/sql/gh-3199-no-mem-leaks.result | 24 +- test/sql/gh-3888-values-blob-assert.result | 8 +- test/sql/gh-4697-scalar-bool-sort-cmp.result | 4 +- test/sql/icu-upper-lower.result | 82 ++--- test/sql/integer-overflow.result | 14 +- test/sql/iproto.result | 18 +- test/sql/max-on-index.result | 6 +- test/sql/misc.result | 12 +- test/sql/persistency.result | 66 ++-- test/sql/prepared.result | 36 +- test/sql/row-count.result | 40 +-- test/sql/transition.result | 66 ++-- test/sql/types.result | 224 ++++++------ 27 files changed, 688 insertions(+), 580 deletions(-) -- 2.21.0 (Apple Git-122)
next reply other threads:[~2020-06-11 15:18 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-11 15:18 Roman Khabibov [this message] 2020-06-11 15:18 ` [Tarantool-patches] [PATCH v3 1/2] sql: use unify pattern for column names Roman Khabibov 2020-06-15 21:59 ` Vladislav Shpilevoy 2020-06-22 21:14 ` roman 2020-06-23 23:12 ` Vladislav Shpilevoy 2020-06-25 14:35 ` Roman Khabibov 2020-06-25 21:25 ` Vladislav Shpilevoy 2020-06-27 11:50 ` Roman Khabibov 2020-06-29 20:08 ` Vladislav Shpilevoy 2020-06-29 23:46 ` Roman Khabibov 2020-06-30 21:23 ` Vladislav Shpilevoy 2020-07-01 12:45 ` Roman Khabibov 2020-07-01 21:25 ` Vladislav Shpilevoy 2020-07-02 15:55 ` Roman Khabibov 2020-06-11 15:18 ` [Tarantool-patches] [PATCH v3 2/2] sql: print span more properly Roman Khabibov 2020-06-15 22:18 ` Vladislav Shpilevoy 2020-06-22 21:14 ` roman 2020-06-23 23:12 ` Vladislav Shpilevoy 2020-07-02 15:55 ` Roman Khabibov 2020-07-02 19:06 ` Nikita Pettik
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200611151853.24398-1-roman.habibov@tarantool.org \ --to=roman.habibov@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v3 0/2] Use-unify-pattern-for-column-names' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox