From: Nikita Pettik <korablev@tarantool.org>
To: tarantool-patches@dev.tarantool.org
Cc: v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] vinyl: rotate mem during index build on demand
Date: Wed, 10 Jun 2020 15:27:01 +0000 [thread overview]
Message-ID: <20200610152701.GA16393@tarantool.org> (raw)
In-Reply-To: <7407b62139349ee3904a674490a6222b0c960a1c.1591292549.git.korablev@tarantool.org>
On 04 Jun 20:49, Nikita Pettik wrote:
> Meanwhile in 17f6af7dc the similar problem has been fixed, still it may
> appear that in-memory level of secondary index being constructed has
> lagging memory generation (in other words, it's values is less than
> the value of current global generation). Such situation can be achieved
> if yield which is required to check uniqueness of value being inserted
> is too long. In this time gap other space may trigger dump process
> bumping global memory generation counter, but dump itself is still not
> yet scheduled.
>
> So to get rid of generations mismatch, let's rotate in-memory level
> after yield on demand.
>
> Closes #5042
> ---
> Branch: https://github.com/tarantool/tarantool/tree/np/gh-5042-rotate-mem-after-yield
> Issue: https://github.com/tarantool/tarantool/issues/5042
>
> @ChangeLog:
> * Fix crash due to triggered dump process during secondary index creation (gh-5042).
>
Pushed without test to master, 2.4, 2.3 and 1.10. Changelogs are updated
correspondingly. Test will be pushed as a follow-up as soon as it gets
second ack.
prev parent reply other threads:[~2020-06-10 15:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 17:49 Nikita Pettik
2020-06-04 20:23 ` Konstantin Osipov
2020-06-04 22:32 ` Nikita Pettik
2020-06-04 22:52 ` Konstantin Osipov
2020-06-05 11:18 ` Nikita Pettik
2020-06-05 11:33 ` Konstantin Osipov
2020-06-06 8:38 ` Aleksandr Lyapunov
2020-06-07 15:51 ` Vladislav Shpilevoy
2020-06-09 22:34 ` Nikita Pettik
2020-06-15 13:54 ` Nikita Pettik
2020-06-23 22:43 ` Vladislav Shpilevoy
2020-06-23 23:11 ` Nikita Pettik
2020-07-22 22:54 ` Vladislav Shpilevoy
2020-06-10 15:27 ` Nikita Pettik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610152701.GA16393@tarantool.org \
--to=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] vinyl: rotate mem during index build on demand' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox