Re: [Tarantool-patches] [PATCH] sql: display collation in metadata for scalar

[Kirill Yukhin <kyukhin@tarantool.org>]

Hello,

Thanks for the patch. Few nits inlined.

Where is ChangeLog entry?

Fix it and it will be LGTM.

On 10 июн 15:47, Roman Khabibov wrote:
> Fix bug with the  display of collation for scalar fields in

Double space.

> <SELECT> result, when sql_full_metadata is enabled.
> 
> Closes #4755
> ---
> 
> Branch: https://github.com/tarantool/tarantool/tree/romanhabibov/gh-4755-scalar-collation
> Issue: https://github.com/tarantool/tarantool/issues/4755
> 
>  src/box/sql/select.c                          |  7 +--
>  .../gh-4755-scalar-collation-metadata.result  | 52 +++++++++++++++++++
>  ...gh-4755-scalar-collation-metadata.test.lua | 18 +++++++
>  3 files changed, 74 insertions(+), 3 deletions(-)
>  create mode 100644 test/sql/gh-4755-scalar-collation-metadata.result
>  create mode 100755 test/sql/gh-4755-scalar-collation-metadata.test.lua
> 
> diff --git a/test/sql/gh-4755-scalar-collation-metadata.result b/test/sql/gh-4755-scalar-collation-metadata.result
> new file mode 100644
> index 000000000..eef2d86ad
> --- /dev/null
> +++ b/test/sql/gh-4755-scalar-collation-metadata.result
> @@ -0,0 +1,52 @@
> +-- test-run result file version 2
> +env = require('test_run')
> + | ---
> + | ...
> +test_run = env.new()
> + | ---
> + | ...
> +
> +--
> +-- gh-4755: Collation in metadata must be displayed as for string
> +-- filed as for scalar field.

Start with lowercase, please. Re-phrase it: "... for both string and scalar field types ..."

--
Regards, Kirill Yukhin