From: Sergey Ostanevich <sergos@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/2] box/applier: fix typo
Date: Wed, 10 Jun 2020 12:18:14 +0300 [thread overview]
Message-ID: <20200610091814.GH50@tarantool.org> (raw)
In-Reply-To: <20200609125302.279888-2-gorcunov@gmail.com>
Hi!
Thanks for the catch!
LGTM
Sergos.
On 09 июн 15:53, Cyrill Gorcunov wrote:
> fixup 3210e1e6f867cfd1c1f65e05f28a32deae63c172
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
> src/box/applier.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/box/applier.cc b/src/box/applier.cc
> index 1dc977424..cf7215d43 100644
> --- a/src/box/applier.cc
> +++ b/src/box/applier.cc
> @@ -271,7 +271,7 @@ applier_on_confirm(struct trigger *trig, void *data)
> static int
> process_confirm(struct request *request)
> {
> - assert(request->header->type = IPROTO_CONFIRM);
> + assert(request->header->type == IPROTO_CONFIRM);
> uint32_t replica_id;
> struct txn *txn = in_txn();
> int64_t *lsn = (int64_t *) region_alloc(&txn->region, sizeof(int64_t));
> --
> 2.26.2
>
next prev parent reply other threads:[~2020-06-10 9:18 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 12:20 [Tarantool-patches] [PATCH 0/8] wait for lsn and confirm Serge Petrenko
2020-06-09 12:20 ` [Tarantool-patches] [PATCH 1/8] replication: introduce space.is_sync option Serge Petrenko
2020-06-10 23:51 ` Vladislav Shpilevoy
2020-06-18 22:27 ` Leonid Vasiliev
2020-06-21 16:24 ` Vladislav Shpilevoy
2020-06-09 12:20 ` [Tarantool-patches] [PATCH 2/8] replication: introduce replication_sync_quorum cfg Serge Petrenko
2020-06-10 23:51 ` Vladislav Shpilevoy
2020-06-15 23:05 ` Vladislav Shpilevoy
2020-06-18 22:54 ` Leonid Vasiliev
2020-06-19 17:45 ` Serge Petrenko
2020-06-21 16:25 ` Vladislav Shpilevoy
2020-06-09 12:20 ` [Tarantool-patches] [PATCH 3/8] txn: add TXN_WAIT_ACK flag Serge Petrenko
2020-06-18 23:12 ` Leonid Vasiliev
2020-06-21 16:25 ` Vladislav Shpilevoy
2020-06-22 9:44 ` Serge Petrenko
2020-06-23 22:13 ` Vladislav Shpilevoy
2020-06-09 12:20 ` [Tarantool-patches] [PATCH 4/8] replication: make sync transactions wait quorum Serge Petrenko
2020-06-10 23:51 ` Vladislav Shpilevoy
2020-06-11 14:57 ` Vladislav Shpilevoy
2020-06-15 23:05 ` Vladislav Shpilevoy
2020-06-19 12:39 ` Leonid Vasiliev
2020-06-25 21:48 ` Vladislav Shpilevoy
2020-06-09 12:20 ` [Tarantool-patches] [PATCH 5/8] txn_limbo: follow-up fixes Serge Petrenko
2020-06-10 23:51 ` Vladislav Shpilevoy
2020-06-11 8:46 ` Serge Petrenko
2020-06-11 13:01 ` Vladislav Shpilevoy
2020-06-09 12:20 ` [Tarantool-patches] [PATCH 6/8] txn_limbo: fix instance id assignment Serge Petrenko
2020-06-10 23:51 ` Vladislav Shpilevoy
2020-06-09 12:20 ` [Tarantool-patches] [PATCH 7/8] xrow: introduce CONFIRM entry Serge Petrenko
2020-06-19 15:18 ` Leonid Vasiliev
2020-06-22 10:14 ` Serge Petrenko
2020-06-23 8:33 ` Serge Petrenko
2020-06-09 12:20 ` [Tarantool-patches] [PATCH 8/8] replication: write and read CONFIRM entries Serge Petrenko
2020-06-10 23:51 ` Vladislav Shpilevoy
2020-06-11 8:56 ` Serge Petrenko
2020-06-11 13:04 ` Vladislav Shpilevoy
2020-06-11 14:57 ` Vladislav Shpilevoy
2020-06-15 23:05 ` Vladislav Shpilevoy
2020-06-18 11:32 ` Leonid Vasiliev
2020-06-18 21:49 ` Vladislav Shpilevoy
2020-06-19 17:48 ` Serge Petrenko
2020-06-19 17:50 ` Serge Petrenko
2020-06-23 8:35 ` Serge Petrenko
2020-06-20 15:06 ` Leonid Vasiliev
2020-06-22 10:34 ` Serge Petrenko
2020-06-23 8:34 ` Serge Petrenko
2020-06-25 22:04 ` Vladislav Shpilevoy
2020-06-25 22:31 ` Vladislav Shpilevoy
2020-06-26 10:58 ` Serge Petrenko
2020-06-09 12:53 ` [Tarantool-patches] [PATCH 0/2] A few fixes for building Cyrill Gorcunov
2020-06-09 12:53 ` [Tarantool-patches] [PATCH 1/2] box/applier: fix typo Cyrill Gorcunov
2020-06-10 9:18 ` Sergey Ostanevich [this message]
2020-06-09 12:53 ` [Tarantool-patches] [PATCH 2/2] box: use tnt_raise for quorum check Cyrill Gorcunov
2020-06-10 9:17 ` Sergey Ostanevich
2020-06-10 10:45 ` Serge Petrenko
2020-06-22 21:51 ` [Tarantool-patches] [PATCH 0/8] wait for lsn and confirm Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610091814.GH50@tarantool.org \
--to=sergos@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/2] box/applier: fix typo' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox