From: Sergey Bronnikov <sergeyb@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 1/3] test: update unit test lib to produce TAP-compliant output
Date: Tue, 9 Jun 2020 21:25:48 +0300 [thread overview]
Message-ID: <20200609182548.GE67772@pony.bronevichok.ru> (raw)
In-Reply-To: <bd73a954-b679-932b-b649-e66f8722b98f@tarantool.org>
Hi!
Thanks for review!
On 01:55 Tue 09 Jun , Vladislav Shpilevoy wrote:
> Hi! Thanks for the patch!
>
> > diff --git a/test/unit/unit.h b/test/unit/unit.h
> > index 43c301b28..b0f9e7f9f 100644
> > --- a/test/unit/unit.h
> > +++ b/test/unit/unit.h
> > @@ -129,6 +126,16 @@ int check_plan(void);
> > } \
> > }
> >
> > +#define header() do { \
> > + _space(stdout); \
> > + printf("# *** %s ***\n", __func__); \
> > +} while(0)
> > +
> > +#define footer() do { \
> > + _space(stdout); \
> > + printf("# *** %s: done ***\n", __func__); \
>
> All the other alignments use tabs. Lets use tabs here too.
Fixed in a branch too.
next prev parent reply other threads:[~2020-06-09 18:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 15:58 [Tarantool-patches] [PATCH v2 0/3] Make unit tests TAP-compliant sergeyb
2020-06-08 15:58 ` [Tarantool-patches] [PATCH v2 1/3] test: update unit test lib to produce TAP-compliant output sergeyb
2020-06-08 23:55 ` Vladislav Shpilevoy
2020-06-09 18:25 ` Sergey Bronnikov [this message]
2020-06-08 15:58 ` [Tarantool-patches] [PATCH v2 2/3] test: update unit tests to make them TAP-compliant sergeyb
2020-06-08 23:55 ` Vladislav Shpilevoy
2020-06-09 16:04 ` Sergey Bronnikov
2020-06-11 18:42 ` Vladislav Shpilevoy
2020-06-08 15:58 ` [Tarantool-patches] [PATCH v2 3/3] msgpuck: bump version to make test output TAP-compliant sergeyb
2020-06-08 16:03 ` [Tarantool-patches] [PATCH v2 4/3][msgpuck] test: " Sergey Bronnikov
2020-06-11 18:42 ` [Tarantool-patches] [PATCH v2 4/3] test: add additional checks Vladislav Shpilevoy
2020-06-11 18:42 ` [Tarantool-patches] [PATCH v2 0/3] Make unit tests TAP-compliant Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200609182548.GE67772@pony.bronevichok.ru \
--to=sergeyb@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 1/3] test: update unit test lib to produce TAP-compliant output' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox